From 7f4c2ea378b98162fd7d3740293cfb2dfecbfc90 Mon Sep 17 00:00:00 2001 From: Bjorn Bringert Date: Wed, 22 Jul 2009 12:49:17 +0100 Subject: [PATCH] Fix SQL generated by updateWithOnConflict() Before, SQLiteDatabase.updateWithOnConflict() method generated syntactically invalid SQL if the ConflictAlgorithm was non-null. For example, it would generate "UPDATE OR REPLACEshortcuts SET ...", when it should be "UPDATE OR REPLACE shortcuts SET ...". Fixes http://b/issue?id=1995470 --- core/java/android/database/sqlite/SQLiteDatabase.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/core/java/android/database/sqlite/SQLiteDatabase.java b/core/java/android/database/sqlite/SQLiteDatabase.java index 7d331dc51df55..184d6dced8c70 100644 --- a/core/java/android/database/sqlite/SQLiteDatabase.java +++ b/core/java/android/database/sqlite/SQLiteDatabase.java @@ -1412,8 +1412,9 @@ public class SQLiteDatabase extends SQLiteClosable { StringBuilder sql = new StringBuilder(120); sql.append("UPDATE "); if (algorithm != null) { - sql.append(" OR "); + sql.append("OR "); sql.append(algorithm.value()); + sql.append(" "); } sql.append(table);