From 7eec37989f1d030d8f933712e6cb2bff8d9e4104 Mon Sep 17 00:00:00 2001 From: Phil Weaver Date: Tue, 14 Feb 2017 16:51:55 -0800 Subject: [PATCH] Suppress a11y shortcut on emergency dialer Suppressing whenever the keyguard is locked, not just when it's showing. This should reduce false triggering. Bug: 34820720 Test: Verfied that shortcut no longer activates on emergency dialer or lock screen. Change-Id: Ic43c11798f04217c2871efe7d0fa21dbf61fd953 --- core/java/android/view/WindowManagerGlobal.java | 6 ++++-- .../java/com/android/server/policy/PhoneWindowManager.java | 4 ++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/core/java/android/view/WindowManagerGlobal.java b/core/java/android/view/WindowManagerGlobal.java index fc6448ad7eac7..c7e8dee3da833 100644 --- a/core/java/android/view/WindowManagerGlobal.java +++ b/core/java/android/view/WindowManagerGlobal.java @@ -167,8 +167,10 @@ public final class WindowManagerGlobal { sWindowManagerService = IWindowManager.Stub.asInterface( ServiceManager.getService("window")); try { - sWindowManagerService = getWindowManagerService(); - ValueAnimator.setDurationScale(sWindowManagerService.getCurrentAnimatorScale()); + if (sWindowManagerService != null) { + ValueAnimator.setDurationScale( + sWindowManagerService.getCurrentAnimatorScale()); + } } catch (RemoteException e) { throw e.rethrowFromSystemServer(); } diff --git a/services/core/java/com/android/server/policy/PhoneWindowManager.java b/services/core/java/com/android/server/policy/PhoneWindowManager.java index 3e051571aab0b..477bb7f4b1544 100644 --- a/services/core/java/com/android/server/policy/PhoneWindowManager.java +++ b/services/core/java/com/android/server/policy/PhoneWindowManager.java @@ -5736,7 +5736,7 @@ public class PhoneWindowManager implements WindowManagerPolicy { mScreenshotChordVolumeDownKeyConsumed = false; cancelPendingPowerKeyAction(); interceptScreenshotChord(); - if (!keyguardActive) { + if (!isKeyguardLocked()) { interceptAccessibilityShortcutChord(); } } @@ -5754,7 +5754,7 @@ public class PhoneWindowManager implements WindowManagerPolicy { mA11yShortcutChordVolumeUpKeyConsumed = false; cancelPendingPowerKeyAction(); cancelPendingScreenshotChordAction(); - if (!keyguardActive) { + if (!isKeyguardLocked()) { interceptAccessibilityShortcutChord(); } }