Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Fix PullUidProvider unregistering on config update" into rvc-dev

Browse Source
This commit is contained in:
Tej Singh
2020-04-22 05:29:49 +00:00
committed by Android (Google) Code Review
parent 36eb8c05dc 3eb9cede0b
commit 7df1a94f78
6 changed files with 38 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
cmds/statsd/src/external/StatsPullerManager.cpp vendored
View File

@@ -252,9 +252,13 @@ void StatsPullerManager::RegisterPullUidProvider(const ConfigKey& configKey,
mPullUidProviders[configKey] = provider; mPullUidProviders[configKey] = provider;
} }
void StatsPullerManager::UnregisterPullUidProvider(const ConfigKey& configKey) { void StatsPullerManager::UnregisterPullUidProvider(const ConfigKey& configKey,
wp<PullUidProvider> provider) {
std::lock_guard<std::mutex> _l(mLock); std::lock_guard<std::mutex> _l(mLock);
mPullUidProviders.erase(configKey); const auto& it = mPullUidProviders.find(configKey);
if (it != mPullUidProviders.end() && it->second == provider) {
mPullUidProviders.erase(it);
}
} }
void StatsPullerManager::OnAlarmFired(int64_t elapsedTimeNs) { void StatsPullerManager::OnAlarmFired(int64_t elapsedTimeNs) {

7
cmds/statsd/src/external/StatsPullerManager.h vendored
View File

@@ -78,11 +78,12 @@ public:
wp<PullDataReceiver> receiver); wp<PullDataReceiver> receiver);
// Registers a pull uid provider for the config key. When pulling atoms, it will be used to // Registers a pull uid provider for the config key. When pulling atoms, it will be used to
// determine which atoms to pull from. // determine which uids to pull from.
virtual void RegisterPullUidProvider(const ConfigKey& configKey, wp<PullUidProvider> provider); virtual void RegisterPullUidProvider(const ConfigKey& configKey, wp<PullUidProvider> provider);
// Unregister a pull uid provider. // Unregister a pull uid provider.
virtual void UnregisterPullUidProvider(const ConfigKey& configKey); virtual void UnregisterPullUidProvider(const ConfigKey& configKey,
wp<PullUidProvider> provider);
// Verify if we know how to pull for this matcher // Verify if we know how to pull for this matcher
bool PullerForMatcherExists(int tagId) const; bool PullerForMatcherExists(int tagId) const;
@@ -180,6 +181,8 @@ private:
FRIEND_TEST(ValueMetricE2eTest, TestPulledEvents); FRIEND_TEST(ValueMetricE2eTest, TestPulledEvents);
FRIEND_TEST(ValueMetricE2eTest, TestPulledEvents_LateAlarm); FRIEND_TEST(ValueMetricE2eTest, TestPulledEvents_LateAlarm);
FRIEND_TEST(ValueMetricE2eTest, TestPulledEvents_WithActivation); FRIEND_TEST(ValueMetricE2eTest, TestPulledEvents_WithActivation);
FRIEND_TEST(StatsLogProcessorTest, TestPullUidProviderSetOnConfigUpdate);
}; };
} // namespace statsd } // namespace statsd

2
cmds/statsd/src/metrics/MetricsManager.cpp
View File

@@ -189,7 +189,7 @@ MetricsManager::~MetricsManager() {
StateManager::getInstance().unregisterListener(atomId, it); StateManager::getInstance().unregisterListener(atomId, it);
} }
} }
mPullerManager->UnregisterPullUidProvider(mConfigKey); mPullerManager->UnregisterPullUidProvider(mConfigKey, this);
VLOG("~MetricsManager()"); VLOG("~MetricsManager()");
} }

2
cmds/statsd/tests/MetricsManager_test.cpp
View File

@@ -528,7 +528,7 @@ TEST(MetricsManagerTest, TestLogSources) {
})); }));
sp<MockStatsPullerManager> pullerManager = new StrictMock<MockStatsPullerManager>(); sp<MockStatsPullerManager> pullerManager = new StrictMock<MockStatsPullerManager>();
EXPECT_CALL(*pullerManager, RegisterPullUidProvider(kConfigKey, _)).Times(1); EXPECT_CALL(*pullerManager, RegisterPullUidProvider(kConfigKey, _)).Times(1);
EXPECT_CALL(*pullerManager, UnregisterPullUidProvider(kConfigKey)).Times(1); EXPECT_CALL(*pullerManager, UnregisterPullUidProvider(kConfigKey, _)).Times(1);
sp<AlarmMonitor> anomalyAlarmMonitor; sp<AlarmMonitor> anomalyAlarmMonitor;
sp<AlarmMonitor> periodicAlarmMonitor; sp<AlarmMonitor> periodicAlarmMonitor;

23
cmds/statsd/tests/StatsLogProcessor_test.cpp
View File

@@ -301,6 +301,29 @@ TEST(StatsLogProcessorTest, TestOnDumpReportEraseData) {
EXPECT_TRUE(noData); EXPECT_TRUE(noData);
} }
TEST(StatsLogProcessorTest, TestPullUidProviderSetOnConfigUpdate) {
// Setup simple config key corresponding to empty config.
sp<UidMap> m = new UidMap();
sp<StatsPullerManager> pullerManager = new StatsPullerManager();
sp<AlarmMonitor> anomalyAlarmMonitor;
sp<AlarmMonitor> subscriberAlarmMonitor;
StatsLogProcessor p(
m, pullerManager, anomalyAlarmMonitor, subscriberAlarmMonitor, 0,
[](const ConfigKey& key) { return true; },
[](const int&, const vector<int64_t>&) { return true; });
ConfigKey key(3, 4);
StatsdConfig config = MakeConfig(false);
p.OnConfigUpdated(0, key, config);
EXPECT_NE(pullerManager->mPullUidProviders.find(key), pullerManager->mPullUidProviders.end());
config.add_default_pull_packages("AID_STATSD");
p.OnConfigUpdated(5, key, config);
EXPECT_NE(pullerManager->mPullUidProviders.find(key), pullerManager->mPullUidProviders.end());
p.OnConfigRemoved(key);
EXPECT_EQ(pullerManager->mPullUidProviders.find(key), pullerManager->mPullUidProviders.end());
}
TEST(StatsLogProcessorTest, TestActiveConfigMetricDiskWriteRead) { TEST(StatsLogProcessorTest, TestActiveConfigMetricDiskWriteRead) {
int uid = 1111; int uid = 1111;

3
cmds/statsd/tests/metrics/metrics_test_helper.h
View File

@@ -44,7 +44,8 @@ public:
vector<std::shared_ptr<LogEvent>>* data, bool useUids)); vector<std::shared_ptr<LogEvent>>* data, bool useUids));
MOCK_METHOD2(RegisterPullUidProvider, MOCK_METHOD2(RegisterPullUidProvider,
void(const ConfigKey& configKey, wp<PullUidProvider> provider)); void(const ConfigKey& configKey, wp<PullUidProvider> provider));
MOCK_METHOD1(UnregisterPullUidProvider, void(const ConfigKey& configKey)); MOCK_METHOD2(UnregisterPullUidProvider,
void(const ConfigKey& configKey, wp<PullUidProvider> provider));
}; };
class MockUidMap : public UidMap { class MockUidMap : public UidMap {