Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Add a default string for failures." into sc-qpr1-dev

Browse Source
This commit is contained in:
Joe Bolinger
2021-09-01 22:05:34 +00:00
committed by Android (Google) Code Review
parent 89c568a0bd 1cf97a94e0
commit 7d26092122
4 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
core/java/android/hardware/face/FaceManager.java
View File

@@ -794,9 +794,9 @@ public class FaceManager implements BiometricAuthenticator, BiometricFaceConstan
// This is used as a last resort in case a vendor string is missing // This is used as a last resort in case a vendor string is missing
// It should not happen for anything other than FACE_ERROR_VENDOR, but // It should not happen for anything other than FACE_ERROR_VENDOR, but
// warn and use the default if all else fails. // warn and use the default if all else fails.
// TODO(b/196639965): update string
Slog.w(TAG, "Invalid error message: " + errMsg + ", " + vendorCode); Slog.w(TAG, "Invalid error message: " + errMsg + ", " + vendorCode);
return ""; return context.getString(
com.android.internal.R.string.face_error_vendor_unknown);
} }
/** /**

4
core/java/android/hardware/fingerprint/FingerprintManager.java
View File

@@ -1390,9 +1390,9 @@ public class FingerprintManager implements BiometricAuthenticator, BiometricFing
// This is used as a last resort in case a vendor string is missing // This is used as a last resort in case a vendor string is missing
// It should not happen for anything other than FINGERPRINT_ERROR_VENDOR, but // It should not happen for anything other than FINGERPRINT_ERROR_VENDOR, but
// warn and use the default if all else fails. // warn and use the default if all else fails.
// TODO(b/196639965): update string
Slog.w(TAG, "Invalid error message: " + errMsg + ", " + vendorCode); Slog.w(TAG, "Invalid error message: " + errMsg + ", " + vendorCode);
return ""; return context.getString(
com.android.internal.R.string.fingerprint_error_vendor_unknown);
} }
/** /**

4
core/res/res/values/strings.xml
View File

@@ -1650,6 +1650,8 @@
<!-- Array containing custom error messages from vendor. Vendor is expected to add and translate these strings --> <!-- Array containing custom error messages from vendor. Vendor is expected to add and translate these strings -->
<string-array name="fingerprint_error_vendor"> <string-array name="fingerprint_error_vendor">
</string-array> </string-array>
<!-- Default error message to use when fingerprint_error_vendor does not contain a message. [CHAR LIMIT=NONE] -->
<string name="fingerprint_error_vendor_unknown">Something went wrong. Try again.</string>
<!-- Content description which should be used for the fingerprint icon. --> <!-- Content description which should be used for the fingerprint icon. -->
<string name="fingerprint_icon_content_description">Fingerprint icon</string> <string name="fingerprint_icon_content_description">Fingerprint icon</string>
@@ -1760,6 +1762,8 @@
<!-- Array containing custom error messages from vendor. Vendor is expected to add and translate these strings --> <!-- Array containing custom error messages from vendor. Vendor is expected to add and translate these strings -->
<string-array name="face_error_vendor"> <string-array name="face_error_vendor">
</string-array> </string-array>
<!-- Default error message to use when face_error_vendor does not contain a message. [CHAR LIMIT=NONE] -->
<string name="face_error_vendor_unknown">Something went wrong. Try again.</string>
<!-- Content description which should be used for the face icon. [CHAR LIMIT=10] --> <!-- Content description which should be used for the face icon. [CHAR LIMIT=10] -->
<string name="face_icon_content_description">Face icon</string> <string name="face_icon_content_description">Face icon</string>

2
core/res/res/values/symbols.xml
View File

@@ -2525,6 +2525,7 @@
<java-symbol type="string" name="fingerprint_error_no_space" /> <java-symbol type="string" name="fingerprint_error_no_space" />
<java-symbol type="string" name="fingerprint_error_timeout" /> <java-symbol type="string" name="fingerprint_error_timeout" />
<java-symbol type="array" name="fingerprint_error_vendor" /> <java-symbol type="array" name="fingerprint_error_vendor" />
<java-symbol type="string" name="fingerprint_error_vendor_unknown" />
<java-symbol type="string" name="fingerprint_acquired_partial" /> <java-symbol type="string" name="fingerprint_acquired_partial" />
<java-symbol type="string" name="fingerprint_acquired_insufficient" /> <java-symbol type="string" name="fingerprint_acquired_insufficient" />
<java-symbol type="string" name="fingerprint_acquired_imager_dirty" /> <java-symbol type="string" name="fingerprint_acquired_imager_dirty" />
@@ -2564,6 +2565,7 @@
<java-symbol type="string" name="face_error_no_space" /> <java-symbol type="string" name="face_error_no_space" />
<java-symbol type="string" name="face_error_timeout" /> <java-symbol type="string" name="face_error_timeout" />
<java-symbol type="array" name="face_error_vendor" /> <java-symbol type="array" name="face_error_vendor" />
<java-symbol type="string" name="face_error_vendor_unknown" />
<java-symbol type="string" name="face_error_canceled" /> <java-symbol type="string" name="face_error_canceled" />
<java-symbol type="string" name="face_error_user_canceled" /> <java-symbol type="string" name="face_error_user_canceled" />
<java-symbol type="string" name="face_error_lockout" /> <java-symbol type="string" name="face_error_lockout" />