Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[DO NOT MERGE] Fix fingerprint enrollment finished Checkmark drawable does not

Browse Source 
apply the correct theme color

Change to correct android:fillColor reference for
udfps_enroll_checkmark.xml drawable.

Bug: 250037527

Test: manual
Test: atest SystemUITests
Change-Id: Iba8955f584073c4600a2771813179752ea274e8c
This commit is contained in:
Jason Chang
2022-11-18 10:47:03 +00:00
parent 818a28d53a
commit 7cbf8ebb90
2 changed files with 52 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/SystemUI/res/drawable/udfps_enroll_checkmark.xml
View File

@@ -26,10 +26,10 @@
android:fillType="evenOdd"/> android:fillType="evenOdd"/>
<path <path
android:pathData="M27,0C12.088,0 0,12.088 0,27C0,41.912 12.088,54 27,54C41.912,54 54,41.912 54,27C54,12.088 41.912,0 27,0ZM27,3.962C39.703,3.962 50.037,14.297 50.037,27C50.037,39.703 39.703,50.038 27,50.038C14.297,50.038 3.963,39.703 3.963,27C3.963,14.297 14.297,3.962 27,3.962Z" android:pathData="M27,0C12.088,0 0,12.088 0,27C0,41.912 12.088,54 27,54C41.912,54 54,41.912 54,27C54,12.088 41.912,0 27,0ZM27,3.962C39.703,3.962 50.037,14.297 50.037,27C50.037,39.703 39.703,50.038 27,50.038C14.297,50.038 3.963,39.703 3.963,27C3.963,14.297 14.297,3.962 27,3.962Z"
android:fillColor="?attr/biometricsEnrollProgress" android:fillColor="@color/udfps_enroll_progress"
android:fillType="evenOdd"/> android:fillType="evenOdd"/>
<path <path
android:pathData="M23.0899,38.8534L10.4199,26.1824L13.2479,23.3544L23.0899,33.1974L41.2389,15.0474L44.0679,17.8754L23.0899,38.8534Z" android:pathData="M23.0899,38.8534L10.4199,26.1824L13.2479,23.3544L23.0899,33.1974L41.2389,15.0474L44.0679,17.8754L23.0899,38.8534Z"
android:fillColor="?attr/biometricsEnrollProgress" android:fillColor="@color/udfps_enroll_progress"
android:fillType="evenOdd"/> android:fillType="evenOdd"/>
</vector> </vector>

50
packages/SystemUI/tests/src/com/android/systemui/biometrics/UdfpsEnrollViewTest.java Normal file
View File

@@ -0,0 +1,50 @@
/*
* Copyright (C) 2022 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.android.systemui.biometrics;
import static com.google.common.truth.Truth.assertThat;
import android.content.res.Configuration;
import android.graphics.Color;
import android.testing.AndroidTestingRunner;
import androidx.test.filters.SmallTest;
import com.android.systemui.R;
import com.android.systemui.SysuiTestCase;
import org.junit.Test;
import org.junit.runner.RunWith;
@SmallTest
@RunWith(AndroidTestingRunner.class)
public class UdfpsEnrollViewTest extends SysuiTestCase {
private static String ENROLL_PROGRESS_COLOR_LIGHT = "#699FF3";
private static String ENROLL_PROGRESS_COLOR_DARK = "#7DA7F1";
@Test
public void fingerprintUdfpsEnroll_usesCorrectThemeCheckmarkFillColor() {
final Configuration config = mContext.getResources().getConfiguration();
final boolean isDarkThemeOn = (config.uiMode & Configuration.UI_MODE_NIGHT_MASK)
== Configuration.UI_MODE_NIGHT_YES;
final int currentColor = mContext.getColor(R.color.udfps_enroll_progress);
assertThat(currentColor).isEqualTo(Color.parseColor(isDarkThemeOn
? ENROLL_PROGRESS_COLOR_DARK : ENROLL_PROGRESS_COLOR_LIGHT));
}
}