From 7c3d133d65926ee79c65619d7ba237bcb9006c06 Mon Sep 17 00:00:00 2001 From: Julian Odell Date: Fri, 17 Sep 2021 08:18:01 -0700 Subject: [PATCH] Notify content capture on detach before setting attachInfo to null. If a view is detached before being removed (which seems common with some recycler list views) then no content capture view removed event is sent (notifyAppearedOrDisappearedForContentCaptureIfNeeded does nothing if mAttachInfo is null). Fix: 200166989 Test: Manual verification using AiAi logging Change-Id: Ic04af005bb4ad425ba8398439f1f47bb6bcb334c --- core/java/android/view/View.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/core/java/android/view/View.java b/core/java/android/view/View.java index f4223fb467f58..cf12955787b15 100644 --- a/core/java/android/view/View.java +++ b/core/java/android/view/View.java @@ -20830,13 +20830,14 @@ public class View implements Drawable.Callback, KeyEvent.Callback, mPrivateFlags &= ~PFLAG_SCROLL_CONTAINER_ADDED; } + notifyAppearedOrDisappearedForContentCaptureIfNeeded(false); + mAttachInfo = null; if (mOverlay != null) { mOverlay.getOverlayView().dispatchDetachedFromWindow(); } notifyEnterOrExitForAutoFillIfNeeded(false); - notifyAppearedOrDisappearedForContentCaptureIfNeeded(false); } /**