From 7bf91fbc257c2b3032a3d9b83e73e1a971666806 Mon Sep 17 00:00:00 2001 From: Yohei Yukawa Date: Wed, 6 Apr 2022 11:25:47 -0700 Subject: [PATCH] Avoid Rect instantiation in NavigationBarController.Impl This is a preparation to fix Bug 226566506. There should be no behavior change in this CL. Bug: 226566506 Test: presubmit Change-Id: Ib4b8b1ce66bb64c0a710750af4ca95b5b2c9e9e8 --- .../inputmethodservice/NavigationBarController.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/core/java/android/inputmethodservice/NavigationBarController.java b/core/java/android/inputmethodservice/NavigationBarController.java index 03d11515c0a85..bd6c4e1a0c09e 100644 --- a/core/java/android/inputmethodservice/NavigationBarController.java +++ b/core/java/android/inputmethodservice/NavigationBarController.java @@ -151,6 +151,8 @@ final class NavigationBarController { private boolean mDrawLegacyNavigationBarBackground; + private final Rect mTempRect = new Rect(); + Impl(@NonNull InputMethodService inputMethodService) { mService = inputMethodService; } @@ -281,13 +283,12 @@ final class NavigationBarController { touchableRegion.set(originalInsets.touchableRegion); break; } - final Rect navBarRect = new Rect(decor.getLeft(), - decor.getBottom() - systemInsets.bottom, + mTempRect.set(decor.getLeft(), decor.getBottom() - systemInsets.bottom, decor.getRight(), decor.getBottom()); if (touchableRegion == null) { - touchableRegion = new Region(navBarRect); + touchableRegion = new Region(mTempRect); } else { - touchableRegion.union(navBarRect); + touchableRegion.union(mTempRect); } dest.touchableRegion.set(touchableRegion);