From 5d12935f35a04abb39cd02883c8c46d4e0345928 Mon Sep 17 00:00:00 2001 From: Dan Willemsen Date: Wed, 29 Aug 2018 17:22:14 -0700 Subject: [PATCH] Convert aapt to Soong See build/soong/README.md for more information. Test: cd frameworks/base/tools/aapt; mma Test: aapt version Change-Id: Ice97e9b32c53cfed30d68acd5717d8c66712df4c --- tools/aapt/Android.bp | 11 ++++++++++ tools/aapt/Android.mk | 51 ------------------------------------------- tools/aapt/Main.cpp | 7 ++---- 3 files changed, 13 insertions(+), 56 deletions(-) delete mode 100644 tools/aapt/Android.mk diff --git a/tools/aapt/Android.bp b/tools/aapt/Android.bp index e26c9c3fdf63d..a594e5bf0ce15 100644 --- a/tools/aapt/Android.bp +++ b/tools/aapt/Android.bp @@ -98,6 +98,17 @@ cc_library_host_static { ], } +// ========================================================== +// Build the host executable: aapt +// ========================================================== +cc_binary_host { + name: "aapt", + defaults: ["aapt_defaults"], + srcs: ["Main.cpp"], + use_version_lib: true, + static_libs: ["libaapt"], +} + // ========================================================== // Build the host tests: libaapt_tests // ========================================================== diff --git a/tools/aapt/Android.mk b/tools/aapt/Android.mk deleted file mode 100644 index 7bcf631da6522..0000000000000 --- a/tools/aapt/Android.mk +++ /dev/null @@ -1,51 +0,0 @@ -# -# Copyright (C) 2014 The Android Open Source Project -# -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. -# - -ifeq ($(TARGET_BUILD_APPS)$(filter true,$(TARGET_BUILD_PDK)),) - -# ========================================================== -# Setup some common variables for the different build -# targets here. -# ========================================================== -LOCAL_PATH:= $(call my-dir) - -aaptHostStaticLibs := \ - libandroidfw \ - libpng \ - libutils \ - liblog \ - libcutils \ - libexpat \ - libziparchive \ - libbase \ - libz - -aaptCFlags := -Wall -Werror - -# ========================================================== -# Build the host executable: aapt -# ========================================================== -include $(CLEAR_VARS) - -LOCAL_MODULE := aapt -LOCAL_MODULE_HOST_OS := darwin linux windows -LOCAL_CFLAGS := -DAAPT_VERSION=\"$(BUILD_NUMBER_FROM_FILE)\" $(aaptCFlags) -LOCAL_SRC_FILES := Main.cpp -LOCAL_STATIC_LIBRARIES := libaapt $(aaptHostStaticLibs) - -include $(BUILD_HOST_EXECUTABLE) - -endif # No TARGET_BUILD_APPS or TARGET_BUILD_PDK diff --git a/tools/aapt/Main.cpp b/tools/aapt/Main.cpp index d714687ee914f..2f2ef92e72b4b 100644 --- a/tools/aapt/Main.cpp +++ b/tools/aapt/Main.cpp @@ -6,6 +6,7 @@ #include "Main.h" #include "Bundle.h" +#include #include #include #include @@ -20,10 +21,6 @@ using namespace android; static const char* gProgName = "aapt"; -#ifndef AAPT_VERSION - #define AAPT_VERSION "" -#endif - /* * Show version info. All the cool kids do it. */ @@ -32,7 +29,7 @@ int doVersion(Bundle* bundle) if (bundle->getFileSpecCount() != 0) { printf("(ignoring extra arguments)\n"); } - printf("Android Asset Packaging Tool, v0.2-" AAPT_VERSION "\n"); + printf("Android Asset Packaging Tool, v0.2-%s\n", android::build::GetBuildNumber().c_str()); return 0; }