From 32929413ffb54b9338a889e764e5cc0608cb2be6 Mon Sep 17 00:00:00 2001 From: Eric Fischer Date: Mon, 14 Dec 2009 17:33:11 -0800 Subject: [PATCH] Avoid a crash trying to get a substring whose start is after its end. Constrain the start of the extracted text, not just the end, to the length of the content. Approver: ryanpc Bug: 2323813 --- core/java/android/widget/TextView.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/core/java/android/widget/TextView.java b/core/java/android/widget/TextView.java index bcdefb346f2b6..cdaba8a006cc1 100644 --- a/core/java/android/widget/TextView.java +++ b/core/java/android/widget/TextView.java @@ -4531,6 +4531,11 @@ public class TextView extends View implements ViewTreeObserver.OnPreDrawListener // Now use the delta to determine the actual amount of text // we need. partialEndOffset += delta; + if (partialStartOffset > N) { + partialStartOffset = N; + } else if (partialStartOffset < 0) { + partialStartOffset = 0; + } if (partialEndOffset > N) { partialEndOffset = N; } else if (partialEndOffset < 0) {