From db28ed585fb000b5d91b29f0ce8fa27ac1d380ef Mon Sep 17 00:00:00 2001 From: Daniel Sandler Date: Wed, 26 May 2021 04:49:51 +0000 Subject: [PATCH] Increase initial StringBuffer capacity in View.toString. 128 was probably a reasonable number back when class names were shorter, and we only had one flags field, and there were no kids on my lawn. But modern views often exceed 128 bytes when stringified, resulting in another allocation and array copy. 256 ought to be enough for anybody. Change-Id: Ib7d4bc4948eb36f42b0e0d35f672398b3bbcea33 Test: atest, presubmit Fixes: 189276070 --- core/java/android/view/View.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/java/android/view/View.java b/core/java/android/view/View.java index 0acacb60da3fb..4df869828c965 100644 --- a/core/java/android/view/View.java +++ b/core/java/android/view/View.java @@ -6431,7 +6431,7 @@ public class View implements Drawable.Callback, KeyEvent.Callback, @Override public String toString() { - StringBuilder out = new StringBuilder(128); + StringBuilder out = new StringBuilder(256); out.append(getClass().getName()); out.append('{'); out.append(Integer.toHexString(System.identityHashCode(this)));