From ccee75966ae00e9a2426df09c0aa8610e145ad72 Mon Sep 17 00:00:00 2001 From: Seigo Nonaka Date: Wed, 6 May 2015 10:31:47 -0700 Subject: [PATCH] Do nothing if hideSoftInput is called from not focused client. IMMS#hideSoftInput calls IMMS#setImeWindowVisibilityStatusHiddenLocked if it is called from not focused client. However this function changes IMS visibility state and also changes the back key indicator wrongly. IMMS should just ignore IMMS#hideSoftInput from not-focused client. As a preparation to fix b/20764441, this CL partially reverts Ife3a8733b1a1bf43b195ecf4b8c5082b6538d0a0 but shouldn't have any user-visible UX regressions. Bug: 20764441 Change-Id: I60963f1474457ff37cca85e262460dca8105acff --- .../core/java/com/android/server/InputMethodManagerService.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/services/core/java/com/android/server/InputMethodManagerService.java b/services/core/java/com/android/server/InputMethodManagerService.java index 45909db9255ba..638965a18a432 100644 --- a/services/core/java/com/android/server/InputMethodManagerService.java +++ b/services/core/java/com/android/server/InputMethodManagerService.java @@ -2038,11 +2038,9 @@ public class InputMethodManagerService extends IInputMethodManager.Stub if (!mIWindowManager.inputMethodClientHasFocus(client)) { if (DEBUG) Slog.w(TAG, "Ignoring hideSoftInput of uid " + uid + ": " + client); - setImeWindowVisibilityStatusHiddenLocked(); return false; } } catch (RemoteException e) { - setImeWindowVisibilityStatusHiddenLocked(); return false; } }