From e04499ad930ff4f112114683dc9f1e5411d6802b Mon Sep 17 00:00:00 2001 From: Chet Haase Date: Tue, 5 Aug 2014 15:24:43 -0700 Subject: [PATCH] Actually set the internal modal value in ListPopupWindow.setModal() The current code ignores the parameter and sets the internal modal value to true. This has probably gone unnoticed because all framework usage of this method calls it with 'true', except for one case where it sets it to 'false' temporarily, and then to 'true'. Issue #16815832 ListPopupWindow setModal broken Change-Id: I4ac7ab31b4ab91c9959efd4ccf2264a8e381708f --- core/java/android/widget/ListPopupWindow.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/java/android/widget/ListPopupWindow.java b/core/java/android/widget/ListPopupWindow.java index af4644b37208c..6a514bab99849 100644 --- a/core/java/android/widget/ListPopupWindow.java +++ b/core/java/android/widget/ListPopupWindow.java @@ -270,7 +270,7 @@ public class ListPopupWindow { * @param modal {@code true} if the popup window should be modal, {@code false} otherwise. */ public void setModal(boolean modal) { - mModal = true; + mModal = modal; mPopup.setFocusable(modal); }