Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Create HandlerThread for TaskFragmentAnimationRunner

Browse Source 
TaskFragmentAnimationRunner is initialized using the
looper from the caller thread. This may cause a NPE
because the looper may be null if the
TaskFragmentAnimationRunner is initialized from a
non-main thread.

This CL creates a HandlerThread for the
TaskFragmentAnimationRunner so that it can be
initialized from any thread.

Bug: b/207662199
Test: atest CtsWindowManagerJetpackTestCases:ActivityEmbeddingLaunchTests
Change-Id: Id06b03380dc6dfa9122fca293df8948b4374c966
This commit is contained in:
Shivam Agrawal
2021-11-17 11:13:45 -08:00
parent b344d33561
commit 7a696c99da
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
libs/WindowManager/Jetpack/src/androidx/window/extensions/embedding/TaskFragmentAnimationRunner.java
View File

@@ -16,6 +16,7 @@
package androidx.window.extensions.embedding; package androidx.window.extensions.embedding;
import static android.os.Process.THREAD_PRIORITY_DISPLAY;
import static android.view.RemoteAnimationTarget.MODE_CLOSING; import static android.view.RemoteAnimationTarget.MODE_CLOSING;
import static android.view.WindowManager.TRANSIT_OLD_ACTIVITY_CLOSE; import static android.view.WindowManager.TRANSIT_OLD_ACTIVITY_CLOSE;
import static android.view.WindowManager.TRANSIT_OLD_ACTIVITY_OPEN; import static android.view.WindowManager.TRANSIT_OLD_ACTIVITY_OPEN;
@@ -29,7 +30,7 @@ import android.animation.Animator;
import android.animation.ValueAnimator; import android.animation.ValueAnimator;
import android.graphics.Rect; import android.graphics.Rect;
import android.os.Handler; import android.os.Handler;
import android.os.Looper; import android.os.HandlerThread;
import android.os.RemoteException; import android.os.RemoteException;
import android.util.Log; import android.util.Log;
import android.view.IRemoteAnimationFinishedCallback; import android.view.IRemoteAnimationFinishedCallback;
@@ -50,10 +51,14 @@ import java.util.function.BiFunction;
class TaskFragmentAnimationRunner extends IRemoteAnimationRunner.Stub { class TaskFragmentAnimationRunner extends IRemoteAnimationRunner.Stub {
private static final String TAG = "TaskFragAnimationRunner"; private static final String TAG = "TaskFragAnimationRunner";
private final Handler mHandler = new Handler(Looper.myLooper()); private final Handler mHandler;
private final TaskFragmentAnimationSpec mAnimationSpec; private final TaskFragmentAnimationSpec mAnimationSpec;
TaskFragmentAnimationRunner() { TaskFragmentAnimationRunner() {
HandlerThread animationThread = new HandlerThread(
"androidx.window.extensions.embedding", THREAD_PRIORITY_DISPLAY);
animationThread.start();
mHandler = animationThread.getThreadHandler();
mAnimationSpec = new TaskFragmentAnimationSpec(mHandler); mAnimationSpec = new TaskFragmentAnimationSpec(mHandler);
} }