From 8ec2ff65da037da14fa1fe372a24a053d198fc51 Mon Sep 17 00:00:00 2001 From: Mathias Agopian Date: Tue, 6 Sep 2011 17:24:05 -0700 Subject: [PATCH] add an option to EGL to dump stack traces on errors enable by setting debug.egl.callstack to 1 Change-Id: I7fad9ce71b4c4c5ece97d4f9d139348eab742a3c --- opengl/libs/EGL/egl.cpp | 11 +++++++---- opengl/libs/EGL/egl_tls.cpp | 11 +++++++++++ 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/opengl/libs/EGL/egl.cpp b/opengl/libs/EGL/egl.cpp index ca6290872c046..1e4319510e66d 100644 --- a/opengl/libs/EGL/egl.cpp +++ b/opengl/libs/EGL/egl.cpp @@ -148,10 +148,13 @@ static int gl_no_context() { if (egl_tls_t::logNoContextCall()) { LOGE("call to OpenGL ES API with no current context " "(logged once per thread)"); - LOGE("call stack before error:"); - CallStack stack; - stack.update(); - stack.dump(); + char value[PROPERTY_VALUE_MAX]; + property_get("debug.egl.callstack", value, "0"); + if (atoi(value)) { + CallStack stack; + stack.update(); + stack.dump(); + } } return 0; } diff --git a/opengl/libs/EGL/egl_tls.cpp b/opengl/libs/EGL/egl_tls.cpp index 961a61ec2f592..f3c8d2c78337c 100644 --- a/opengl/libs/EGL/egl_tls.cpp +++ b/opengl/libs/EGL/egl_tls.cpp @@ -14,9 +14,13 @@ ** limitations under the License. */ +#include #include #include +#include + +#include #include @@ -69,6 +73,13 @@ void egl_tls_t::setErrorEtcImpl(const char* caller, int line, EGLint error) { if (tls->error != error) { LOGE("%s:%d error %x (%s)", caller, line, error, egl_strerror(error)); tls->error = error; + char value[PROPERTY_VALUE_MAX]; + property_get("debug.egl.callstack", value, "0"); + if (atoi(value)) { + CallStack stack; + stack.update(); + stack.dump(); + } } }