From 79c3779bb1de72610d36e0ce8daf715e04091d1b Mon Sep 17 00:00:00 2001 From: Shumao Hou Date: Wed, 15 Jun 2022 15:47:04 -0700 Subject: [PATCH] BatteryStatsImpl: Add parcel methods for DisplayBatteryStats. DisplayBatteryStats didn't have parcel methods and the estimated multidisplay screen power was always initialized from 0. The estimated screen power of the app will become inaccurate after rebooting. Bug: 235321975 Test: manual test. 1. Unplug the device. 2. Use an app for a while and keep screen on. 3. Capture the first bug report. 4. Reboot the device. 5. Capture the second bug report. The estimated screen power of the app shouldn't become lower after rebooting the device. Author: Shumao Hou Change-Id: If74e285102a7350c17c2fc40a205b2031e82f5f4 --- .../android/internal/os/BatteryStatsImpl.java | 33 ++++++++++++++++++- 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/core/java/com/android/internal/os/BatteryStatsImpl.java b/core/java/com/android/internal/os/BatteryStatsImpl.java index cade7c5c075dd..6a34e83ad3b2f 100644 --- a/core/java/com/android/internal/os/BatteryStatsImpl.java +++ b/core/java/com/android/internal/os/BatteryStatsImpl.java @@ -167,7 +167,7 @@ public class BatteryStatsImpl extends BatteryStats { private static final int MAGIC = 0xBA757475; // 'BATSTATS' // Current on-disk Parcel version. Must be updated when the format of the parcelable changes - public static final int VERSION = 208; + public static final int VERSION = 209; // The maximum number of names wakelocks we will keep track of // per uid; once the limit is reached, we batch the remaining wakelocks @@ -884,6 +884,28 @@ public class BatteryStatsImpl extends BatteryStats { screenBrightnessTimers[i].reset(false, elapsedRealtimeUs); } } + + /** + * Write data to summary parcel + */ + public void writeSummaryToParcel(Parcel out, long elapsedRealtimeUs) { + screenOnTimer.writeSummaryFromParcelLocked(out, elapsedRealtimeUs); + screenDozeTimer.writeSummaryFromParcelLocked(out, elapsedRealtimeUs); + for (int i = 0; i < NUM_SCREEN_BRIGHTNESS_BINS; i++) { + screenBrightnessTimers[i].writeSummaryFromParcelLocked(out, elapsedRealtimeUs); + } + } + + /** + * Read data from summary parcel + */ + public void readSummaryFromParcel(Parcel in) { + screenOnTimer.readSummaryFromParcelLocked(in); + screenDozeTimer.readSummaryFromParcelLocked(in); + for (int i = 0; i < NUM_SCREEN_BRIGHTNESS_BINS; i++) { + screenBrightnessTimers[i].readSummaryFromParcelLocked(in); + } + } } DisplayBatteryStats[] mPerDisplayBatteryStats; @@ -17247,6 +17269,10 @@ public class BatteryStatsImpl extends BatteryStats { for (int i=0; i