From 79b75bdbc8a2444d2d8791c2e7c1b48c0f2b6c20 Mon Sep 17 00:00:00 2001 From: William Escande Date: Thu, 11 May 2023 14:32:43 -0700 Subject: [PATCH] Remove bluetooth state change logging from BatteryStats Bug: 281574270 Test: build Change-Id: Ie748edba80eaaaba20fd7369733d53c078679992 (cherry picked from commit 244090ea54a866b9f2d5eda33607934f473fc546) --- core/java/android/os/BatteryStatsManager.java | 12 ++------ .../android/internal/app/IBatteryStats.aidl | 4 --- .../server/am/BatteryStatsService.java | 28 ------------------- 3 files changed, 2 insertions(+), 42 deletions(-) diff --git a/core/java/android/os/BatteryStatsManager.java b/core/java/android/os/BatteryStatsManager.java index 071bdea5e3ac6..955fad3d1a481 100644 --- a/core/java/android/os/BatteryStatsManager.java +++ b/core/java/android/os/BatteryStatsManager.java @@ -520,14 +520,10 @@ public final class BatteryStatsManager { * @param uid calling package uid * @param reason why Bluetooth has been turned on * @param packageName package responsible for this change + * @Deprecated Bluetooth self report its state and no longer call this */ @RequiresPermission(android.Manifest.permission.BLUETOOTH_CONNECT) public void reportBluetoothOn(int uid, int reason, @NonNull String packageName) { - try { - mBatteryStats.noteBluetoothOn(uid, reason, packageName); - } catch (RemoteException e) { - e.rethrowFromSystemServer(); - } } /** @@ -536,14 +532,10 @@ public final class BatteryStatsManager { * @param uid calling package uid * @param reason why Bluetooth has been turned on * @param packageName package responsible for this change + * @Deprecated Bluetooth self report its state and no longer call this */ @RequiresPermission(android.Manifest.permission.BLUETOOTH_CONNECT) public void reportBluetoothOff(int uid, int reason, @NonNull String packageName) { - try { - mBatteryStats.noteBluetoothOff(uid, reason, packageName); - } catch (RemoteException e) { - e.rethrowFromSystemServer(); - } } /** diff --git a/core/java/com/android/internal/app/IBatteryStats.aidl b/core/java/com/android/internal/app/IBatteryStats.aidl index 65394bd87d642..d433cd652606f 100644 --- a/core/java/com/android/internal/app/IBatteryStats.aidl +++ b/core/java/com/android/internal/app/IBatteryStats.aidl @@ -219,10 +219,6 @@ interface IBatteryStats { @EnforcePermission("BATTERY_STATS") long getAwakeTimePlugged(); - @EnforcePermission("BLUETOOTH_CONNECT") - void noteBluetoothOn(int uid, int reason, String packageName); - @EnforcePermission("BLUETOOTH_CONNECT") - void noteBluetoothOff(int uid, int reason, String packageName); @EnforcePermission("UPDATE_DEVICE_STATS") void noteBleScanStarted(in WorkSource ws, boolean isUnoptimized); @EnforcePermission("UPDATE_DEVICE_STATS") diff --git a/services/core/java/com/android/server/am/BatteryStatsService.java b/services/core/java/com/android/server/am/BatteryStatsService.java index 36da888dbc2a7..dc6f8584006e2 100644 --- a/services/core/java/com/android/server/am/BatteryStatsService.java +++ b/services/core/java/com/android/server/am/BatteryStatsService.java @@ -2287,34 +2287,6 @@ public final class BatteryStatsService extends IBatteryStats.Stub } } - /** - * Bluetooth on stat logging - */ - @Override - @EnforcePermission(BLUETOOTH_CONNECT) - public void noteBluetoothOn(int uid, int reason, String packageName) { - super.noteBluetoothOn_enforcePermission(); - - FrameworkStatsLog.write_non_chained(FrameworkStatsLog.BLUETOOTH_ENABLED_STATE_CHANGED, - Binder.getCallingUid(), null, - FrameworkStatsLog.BLUETOOTH_ENABLED_STATE_CHANGED__STATE__ENABLED, - reason, packageName); - } - - /** - * Bluetooth off stat logging - */ - @Override - @EnforcePermission(BLUETOOTH_CONNECT) - public void noteBluetoothOff(int uid, int reason, String packageName) { - super.noteBluetoothOff_enforcePermission(); - - FrameworkStatsLog.write_non_chained(FrameworkStatsLog.BLUETOOTH_ENABLED_STATE_CHANGED, - Binder.getCallingUid(), null, - FrameworkStatsLog.BLUETOOTH_ENABLED_STATE_CHANGED__STATE__DISABLED, - reason, packageName); - } - @Override @EnforcePermission(UPDATE_DEVICE_STATS) public void noteBleScanStarted(final WorkSource ws, final boolean isUnoptimized) {