Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Fix bad arguments handling"

Browse Source
This commit is contained in:
Treehugger Robot
2019-07-08 17:54:25 +00:00
committed by Gerrit Code Review
parent 803648a957 d7ebdb2a0b
commit 79a2b5215d
1 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
services/core/java/com/android/server/net/watchlist/NetworkWatchlistShellCommand.java
View File

@@ -17,8 +17,6 @@
package com.android.server.net.watchlist; package com.android.server.net.watchlist;
import android.content.Context; import android.content.Context;
import android.content.Intent;
import android.net.NetworkWatchlistManager;
import android.os.Binder; import android.os.Binder;
import android.os.ParcelFileDescriptor; import android.os.ParcelFileDescriptor;
import android.os.RemoteException; import android.os.RemoteException;
@@ -26,7 +24,6 @@ import android.os.ShellCommand;
import android.provider.Settings; import android.provider.Settings;
import java.io.FileInputStream; import java.io.FileInputStream;
import java.io.IOException;
import java.io.InputStream; import java.io.InputStream;
import java.io.PrintWriter; import java.io.PrintWriter;
@@ -74,10 +71,12 @@ class NetworkWatchlistShellCommand extends ShellCommand {
try { try {
final String configXmlPath = getNextArgRequired(); final String configXmlPath = getNextArgRequired();
final ParcelFileDescriptor pfd = openFileForSystem(configXmlPath, "r"); final ParcelFileDescriptor pfd = openFileForSystem(configXmlPath, "r");
if (pfd != null) { if (pfd == null) {
final InputStream fileStream = new FileInputStream(pfd.getFileDescriptor()); pw.println("Error: can't open input file " + configXmlPath);
WatchlistConfig.getInstance().setTestMode(fileStream); return -1;
} }
final InputStream fileStream = new FileInputStream(pfd.getFileDescriptor());
WatchlistConfig.getInstance().setTestMode(fileStream);
pw.println("Success!"); pw.println("Success!");
} catch (Exception ex) { } catch (Exception ex) {
pw.println("Error: " + ex.toString()); pw.println("Error: " + ex.toString());