From 32d124e0c0bf51110205af10c8a36758dd887c23 Mon Sep 17 00:00:00 2001 From: Justin Weir Date: Fri, 7 Jul 2023 12:38:33 -0400 Subject: [PATCH] Remove logging present in an ANR stack trace The logging was added for b/245441667, which is fixed, and the toString call was already doing too much work for a log buffer anyway. Fixes: 288791416 Bug: 245441667 Test: presubmits are sufficient Change-Id: I3ee11d833a860c5259957bbc846d2b342223105a --- .../shade/NotificationShadeWindowControllerImpl.java | 1 - .../com/android/systemui/shade/ShadeWindowLogger.kt | 12 +----------- 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/packages/SystemUI/src/com/android/systemui/shade/NotificationShadeWindowControllerImpl.java b/packages/SystemUI/src/com/android/systemui/shade/NotificationShadeWindowControllerImpl.java index 8105a145d15a7..481da52635f01 100644 --- a/packages/SystemUI/src/com/android/systemui/shade/NotificationShadeWindowControllerImpl.java +++ b/packages/SystemUI/src/com/android/systemui/shade/NotificationShadeWindowControllerImpl.java @@ -480,7 +480,6 @@ public class NotificationShadeWindowControllerImpl implements NotificationShadeW private void applyWindowLayoutParams() { if (mDeferWindowLayoutParams == 0 && mLp != null && mLp.copyFrom(mLpChanged) != 0) { - mLogger.logApplyingWindowLayoutParams(mLp); Trace.beginSection("updateViewLayout"); mWindowManager.updateViewLayout(mWindowRootView, mLp); Trace.endSection(); diff --git a/packages/SystemUI/src/com/android/systemui/shade/ShadeWindowLogger.kt b/packages/SystemUI/src/com/android/systemui/shade/ShadeWindowLogger.kt index 51a27cf8989ab..e7a397b0fa09b 100644 --- a/packages/SystemUI/src/com/android/systemui/shade/ShadeWindowLogger.kt +++ b/packages/SystemUI/src/com/android/systemui/shade/ShadeWindowLogger.kt @@ -16,14 +16,13 @@ package com.android.systemui.shade -import android.view.WindowManager -import com.android.systemui.log.dagger.ShadeWindowLog import com.android.systemui.log.ConstantStringsLogger import com.android.systemui.log.ConstantStringsLoggerImpl import com.android.systemui.log.LogBuffer import com.android.systemui.log.core.LogLevel import com.android.systemui.log.core.LogLevel.DEBUG import com.android.systemui.log.core.LogMessage +import com.android.systemui.log.dagger.ShadeWindowLog import javax.inject.Inject private const val TAG = "systemui.shadewindow" @@ -31,15 +30,6 @@ private const val TAG = "systemui.shadewindow" class ShadeWindowLogger @Inject constructor(@ShadeWindowLog private val buffer: LogBuffer) : ConstantStringsLogger by ConstantStringsLoggerImpl(buffer, TAG) { - fun logApplyingWindowLayoutParams(lp: WindowManager.LayoutParams) { - buffer.log( - TAG, - DEBUG, - { str1 = lp.toString() }, - { "Applying new window layout params: $str1" } - ) - } - fun logNewState(state: Any) { buffer.log( TAG,