Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Throw DeadObjectException on failed transaction, not RuntimeException" into mnc-dev

Browse Source
This commit is contained in:
Christopher Tate
2015-06-29 18:54:56 +00:00
committed by Android (Google) Code Review
parent 810d5ed23b ffd5864202
commit 795d95ecd7
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
core/jni/android_util_Binder.cpp
View File

@@ -697,9 +697,11 @@ void signalExceptionForError(JNIEnv* env, jobject obj, status_t err,
} else { } else {
// Heuristic: a payload smaller than this threshold "shouldn't" be too // Heuristic: a payload smaller than this threshold "shouldn't" be too
// big, so it's probably some other, more subtle problem. In practice // big, so it's probably some other, more subtle problem. In practice
// it nearly always means that the remote process died while the binder // it seems to always mean that the remote process died while the binder
// transaction was already in flight. // transaction was already in flight.
exceptionToThrow = "java/lang/RuntimeException"; exceptionToThrow = (canThrowRemoteException)
? "android/os/DeadObjectException"
: "java/lang/RuntimeException";
snprintf(msg, sizeof(msg)-1, snprintf(msg, sizeof(msg)-1,
"Transaction failed on small parcel; remote process probably died"); "Transaction failed on small parcel; remote process probably died");
} }