From 3a05ca923d755b01f985842a75af351945c19ba1 Mon Sep 17 00:00:00 2001 From: Yohei Yukawa Date: Tue, 1 Nov 2022 16:14:04 -0700 Subject: [PATCH] Remove requestCursorUpdatesFromImm() again This CL removes an unused method RemoteInputConnectionImpl#requestCursorUpdatesFromImm(), which was originally introduced [1] then removed [2], and accidentally added again [3]. Anyway, this method is no longer used and can be removed safely. [1]: I3d6b1728d62139785593af14c24cb52bf2c91e31 71aa1a31d1bcb5780829cf963740a8e905175e0d [2]: Ia72a9fe0ceac1798ee1989eaae3906e8e1b696bf 5854c92badb8c6b095f4ddc0c70ea2f6759c5029 [3]: I53bcb62e03ac1c371feb60d1385c88c921754092 3e3ff1a3d298f74246597cb10529e52e96b0d7b9 Bug: 210039666 Test: presubmit Change-Id: I4d0bf0ac371e1f9f214258906231d6ae85bdce3e --- .../RemoteInputConnectionImpl.java | 21 ------------------- 1 file changed, 21 deletions(-) diff --git a/core/java/android/view/inputmethod/RemoteInputConnectionImpl.java b/core/java/android/view/inputmethod/RemoteInputConnectionImpl.java index ead79245609a3..e6b22de3151aa 100644 --- a/core/java/android/view/inputmethod/RemoteInputConnectionImpl.java +++ b/core/java/android/view/inputmethod/RemoteInputConnectionImpl.java @@ -1015,27 +1015,6 @@ final class RemoteInputConnectionImpl extends IRemoteInputConnection.Stub { }); } - /** - * Dispatches {@link InputConnection#requestCursorUpdates(int)}. - * - *

This method is intended to be called only from {@link InputMethodManager}.

- * @param cursorUpdateMode the mode for {@link InputConnection#requestCursorUpdates(int, int)} - * @param cursorUpdateFilter the filter for - * {@link InputConnection#requestCursorUpdates(int, int)} - * @param imeDisplayId displayId on which IME is displayed. - */ - @Dispatching(cancellable = true) - public void requestCursorUpdatesFromImm(int cursorUpdateMode, int cursorUpdateFilter, - int imeDisplayId) { - final int currentSessionId = mCurrentSessionId.get(); - dispatchWithTracing("requestCursorUpdatesFromImm", () -> { - if (currentSessionId != mCurrentSessionId.get()) { - return; // cancelled - } - requestCursorUpdatesInternal(cursorUpdateMode, cursorUpdateFilter, imeDisplayId); - }); - } - @Dispatching(cancellable = true) @Override public void requestCursorUpdates(InputConnectionCommandHeader header, int cursorUpdateMode,