From ef671105e18c64f6ae3ee4e7cad75c641ab95a74 Mon Sep 17 00:00:00 2001 From: Philip Cuadra Date: Mon, 7 Jun 2021 17:21:37 -0700 Subject: [PATCH] Remove tracing for notifyContentCapture These traces get expensive in aggregate due to an increased number of notifyContentCapture events. Remove them. Bug 188836620 Test: Confirmed no notifyContentCapture trace points in systrace Change-Id: I5d77bd9048b2e8cd267187f866dc095792a3f455 --- core/java/android/view/View.java | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/core/java/android/view/View.java b/core/java/android/view/View.java index 8138b3d30ddfc..6d861dd00e9cc 100644 --- a/core/java/android/view/View.java +++ b/core/java/android/view/View.java @@ -9808,23 +9808,9 @@ public class View implements Drawable.Callback, KeyEvent.Callback, */ private void notifyAppearedOrDisappearedForContentCaptureIfNeeded(boolean appeared) { AttachInfo ai = mAttachInfo; - // Skip it while the view is being laided out for the first time + // Skip it while the view is being laid out for the first time if (ai != null && !ai.mReadyForContentCaptureUpdates) return; - if (Trace.isTagEnabled(Trace.TRACE_TAG_VIEW)) { - Trace.traceBegin(Trace.TRACE_TAG_VIEW, - "notifyContentCapture(" + appeared + ") for " + getClass().getSimpleName()); - } - try { - notifyAppearedOrDisappearedForContentCaptureIfNeededNoTrace(appeared); - } finally { - Trace.traceEnd(Trace.TRACE_TAG_VIEW); - } - } - - private void notifyAppearedOrDisappearedForContentCaptureIfNeededNoTrace(boolean appeared) { - AttachInfo ai = mAttachInfo; - // First check if context has client, so it saves a service lookup when it doesn't if (mContext.getContentCaptureOptions() == null) return;