From fba08dd9b4ecd8cb49d69d7537dce220996ec641 Mon Sep 17 00:00:00 2001 From: Yin-Chia Yeh Date: Thu, 2 Apr 2015 14:05:14 -0700 Subject: [PATCH] Camera: update semantics of HIGH_QUALITY mode Codegen doc update. Bug: 19665478 Change-Id: I9ef9ddefcf32b1ff981e0ffa4b440ddf64ba99c2 --- .../camera2/CameraCharacteristics.java | 4 ++-- .../hardware/camera2/CameraMetadata.java | 20 +++++++++---------- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/core/java/android/hardware/camera2/CameraCharacteristics.java b/core/java/android/hardware/camera2/CameraCharacteristics.java index 1503bf5d8c932..f28c96e8d85aa 100644 --- a/core/java/android/hardware/camera2/CameraCharacteristics.java +++ b/core/java/android/hardware/camera2/CameraCharacteristics.java @@ -2354,8 +2354,8 @@ public final class CameraCharacteristics extends CameraMetadataCamera devices that support the MANUAL_POST_PROCESSING capability will always contain * at least one of below mode combinations:

* *

This includes all FULL level devices.

*

Range of valid values:
diff --git a/core/java/android/hardware/camera2/CameraMetadata.java b/core/java/android/hardware/camera2/CameraMetadata.java index 7f901c83dac07..85c574aa136f3 100644 --- a/core/java/android/hardware/camera2/CameraMetadata.java +++ b/core/java/android/hardware/camera2/CameraMetadata.java @@ -852,8 +852,8 @@ public abstract class CameraMetadata { /** *

Color correction processing operates at improved - * quality but reduced capture rate (relative to sensor raw - * output).

+ * quality but the capture rate might be reduced (relative to sensor + * raw output rate)

*

Advanced white balance adjustments above and beyond * the specified white balance pipeline may be applied.

*

If AWB is enabled with {@link CaptureRequest#CONTROL_AWB_MODE android.control.awbMode} != OFF, then @@ -883,8 +883,8 @@ public abstract class CameraMetadata { public static final int COLOR_CORRECTION_ABERRATION_MODE_FAST = 1; /** - *

Aberration correction operates at improved quality but reduced - * capture rate (relative to sensor raw output).

+ *

Aberration correction operates at improved quality but the capture rate might be + * reduced (relative to sensor raw output rate)

* @see CaptureRequest#COLOR_CORRECTION_ABERRATION_MODE */ public static final int COLOR_CORRECTION_ABERRATION_MODE_HIGH_QUALITY = 2; @@ -1797,7 +1797,7 @@ public abstract class CameraMetadata { public static final int EDGE_MODE_FAST = 1; /** - *

Apply high-quality edge enhancement, at a cost of reducing output frame rate.

+ *

Apply high-quality edge enhancement, at a cost of possibly reduced output frame rate.

* @see CaptureRequest#EDGE_MODE */ public static final int EDGE_MODE_HIGH_QUALITY = 2; @@ -1852,7 +1852,7 @@ public abstract class CameraMetadata { /** *

High-quality hot pixel correction is applied, at a cost - * of reducing frame rate relative to sensor raw output.

+ * of possibly reduced frame rate relative to sensor raw output.

*

The hotpixel map may be returned in {@link CaptureResult#STATISTICS_HOT_PIXEL_MAP android.statistics.hotPixelMap}.

* * @see CaptureResult#STATISTICS_HOT_PIXEL_MAP @@ -1894,8 +1894,8 @@ public abstract class CameraMetadata { public static final int NOISE_REDUCTION_MODE_FAST = 1; /** - *

High-quality noise reduction is applied, at the cost of reducing frame rate - * relative to sensor output.

+ *

High-quality noise reduction is applied, at the cost of possibly reduced frame + * rate relative to sensor output.

* @see CaptureRequest#NOISE_REDUCTION_MODE */ public static final int NOISE_REDUCTION_MODE_HIGH_QUALITY = 2; @@ -2032,7 +2032,7 @@ public abstract class CameraMetadata { /** *

Apply high-quality lens shading correction, at the - * cost of reduced frame rate.

+ * cost of possibly reduced frame rate.

* @see CaptureRequest#SHADING_MODE */ public static final int SHADING_MODE_HIGH_QUALITY = 2; @@ -2105,7 +2105,7 @@ public abstract class CameraMetadata { /** *

High-quality gamma mapping and color enhancement will be applied, at - * the cost of reduced frame rate compared to raw sensor output.

+ * the cost of possibly reduced frame rate compared to raw sensor output.

* @see CaptureRequest#TONEMAP_MODE */ public static final int TONEMAP_MODE_HIGH_QUALITY = 2;