Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "ResetLockout should be scheduled on FaceService's handler" into qt-r1-dev

Browse Source
This commit is contained in:
Kevin Chyn
2019-07-28 23:27:56 +00:00
committed by Android (Google) Code Review
parent 6293cba478 7a207e4716
commit 7809a34760
1 changed files with 13 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
services/core/java/com/android/server/biometrics/face/FaceService.java
View File

@@ -344,16 +344,19 @@ public class FaceService extends BiometricServiceBase {
@Override // Binder call @Override // Binder call
public int revokeChallenge(IBinder token) { public int revokeChallenge(IBinder token) {
checkPermission(MANAGE_BIOMETRIC); checkPermission(MANAGE_BIOMETRIC);
// TODO(b/137106905): Schedule binder calls in FaceService to avoid deadlocks. mHandler.post(() -> {
if (getCurrentClient() == null) { // TODO(b/137106905): Schedule binder calls in FaceService to avoid deadlocks.
// if we aren't handling any other HIDL calls (mCurrentClient == null), revoke the if (getCurrentClient() == null) {
// challenge right away. // if we aren't handling any other HIDL calls (mCurrentClient == null), revoke
return startRevokeChallenge(token); // the challenge right away.
} else { startRevokeChallenge(token);
// postpone revoking the challenge until we finish processing the current HIDL call. } else {
mRevokeChallengePending = true; // postpone revoking the challenge until we finish processing the current HIDL
return Status.OK; // call.
} mRevokeChallengePending = true;
}
});
return Status.OK;
} }
@Override // Binder call @Override // Binder call