From b466506595803b7440bbe72b2326bca51aa9a65e Mon Sep 17 00:00:00 2001 From: Mady Mellor Date: Fri, 21 Apr 2023 16:18:30 -0700 Subject: [PATCH] Fix an issue where sometimes we wouldn't animate while dismissing When bubbles are expanded and we drag the currently selected bubble to the dismiss target, we'd fade out the expanded view. In the situation where it was the last bubble being removed, this flag would not get reset. This means the next time the last bubble is dragged out, it wouldn't get animated. To fix this, when the last bubble gets animated out, reset this flag. Bug: 279074302 Test: manual - have 1 bubble, expand it, drag to dismiss it - get another bubble, expand it, drag to dismiss it => while dragging, the expanded view should always fade out Change-Id: Ibc3ddaab7c48e285b7ed25c32711bef7ebdb0dc9 --- .../Shell/src/com/android/wm/shell/bubbles/BubbleStackView.java | 1 + 1 file changed, 1 insertion(+) diff --git a/libs/WindowManager/Shell/src/com/android/wm/shell/bubbles/BubbleStackView.java b/libs/WindowManager/Shell/src/com/android/wm/shell/bubbles/BubbleStackView.java index 1b20f67e42abf..2f10acbf44b6b 100644 --- a/libs/WindowManager/Shell/src/com/android/wm/shell/bubbles/BubbleStackView.java +++ b/libs/WindowManager/Shell/src/com/android/wm/shell/bubbles/BubbleStackView.java @@ -880,6 +880,7 @@ public class BubbleStackView extends FrameLayout final Runnable onBubbleAnimatedOut = () -> { if (getBubbleCount() == 0) { + mExpandedViewTemporarilyHidden = false; mBubbleController.onAllBubblesAnimatedOut(); } };