From 76752c8f021a7f1933b413c64525981755f52d2f Mon Sep 17 00:00:00 2001 From: "Torne (Richard Coles)" Date: Mon, 11 May 2020 14:58:53 -0400 Subject: [PATCH] Deprecate WebSettings.setAppCacheEnabled and related. Chrome will be removing the Application Cache API in future; deprecate the APIs in WebView which allow Android apps to enable it. Test: make offline-sdk-docs Fixes: 156266477 Change-Id: I0feff5289706b5f7985013a18d9cf0e3e6b3ba78 --- api/current.txt | 4 ++-- core/java/android/webkit/WebSettings.java | 8 +++++++- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/api/current.txt b/api/current.txt index 467aa32a7d671..41a74cfae20ac 100644 --- a/api/current.txt +++ b/api/current.txt @@ -58326,9 +58326,9 @@ package android.webkit { method public abstract void setAllowFileAccess(boolean); method @Deprecated public abstract void setAllowFileAccessFromFileURLs(boolean); method @Deprecated public abstract void setAllowUniversalAccessFromFileURLs(boolean); - method public abstract void setAppCacheEnabled(boolean); + method @Deprecated public abstract void setAppCacheEnabled(boolean); method @Deprecated public abstract void setAppCacheMaxSize(long); - method public abstract void setAppCachePath(String); + method @Deprecated public abstract void setAppCachePath(String); method public abstract void setBlockNetworkImage(boolean); method public abstract void setBlockNetworkLoads(boolean); method public abstract void setBuiltInZoomControls(boolean); diff --git a/core/java/android/webkit/WebSettings.java b/core/java/android/webkit/WebSettings.java index 35dd5760d5abf..e224e84a56fec 100644 --- a/core/java/android/webkit/WebSettings.java +++ b/core/java/android/webkit/WebSettings.java @@ -1118,6 +1118,9 @@ public abstract class WebSettings { * {@link #setAppCachePath}. * * @param flag {@code true} if the WebView should enable Application Caches + * @deprecated The Application Cache API is deprecated and this method will + * become a no-op on all Android versions once support is + * removed in Chromium. Consider using Service Workers instead. */ public abstract void setAppCacheEnabled(boolean flag); @@ -1130,6 +1133,9 @@ public abstract class WebSettings { * @param appCachePath a String path to the directory containing * Application Caches files. * @see #setAppCacheEnabled + * @deprecated The Application Cache API is deprecated and this method will + * become a no-op on all Android versions once support is + * removed in Chromium. Consider using Service Workers instead. */ public abstract void setAppCachePath(String appCachePath); @@ -1142,7 +1148,7 @@ public abstract class WebSettings { * It is recommended to leave the maximum size set to the default value. * * @param appCacheMaxSize the maximum size in bytes - * @deprecated In future quota will be managed automatically. + * @deprecated Quota is managed automatically; this method is a no-op. */ @Deprecated public abstract void setAppCacheMaxSize(long appCacheMaxSize);