From 759d8050568fe2b3b502b5a79845183b4dc1da03 Mon Sep 17 00:00:00 2001 From: Andrey Epin Date: Mon, 28 Nov 2022 18:03:36 -0800 Subject: [PATCH] Fix AppPredictionService callbacks comparison IPredictionCallback#equals() does not return true for the same callback passed twice into the service. Compare callback binders instead. Fix: 260650688 Test: manual test Change-Id: Icbdbad54bd36bb8598054915a90424359f7d2863 --- .../android/service/appprediction/AppPredictionService.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/java/android/service/appprediction/AppPredictionService.java b/core/java/android/service/appprediction/AppPredictionService.java index 4f37cd91b11fd..a2ffa5d34219f 100644 --- a/core/java/android/service/appprediction/AppPredictionService.java +++ b/core/java/android/service/appprediction/AppPredictionService.java @@ -328,7 +328,7 @@ public abstract class AppPredictionService extends Service { Slog.e(TAG, "Callback is null, likely the binder has died."); return false; } - return mCallback.equals(callback); + return mCallback.asBinder().equals(callback.asBinder()); } public void destroy() {