From 9974bcf86d16c06754550dbcba15247c6523262a Mon Sep 17 00:00:00 2001 From: Hai Zhang Date: Fri, 31 Mar 2023 21:43:55 +0000 Subject: [PATCH] Fix typo in PID check. Fixes: 272021728 Test: presubmit Change-Id: Id5f84a2985e5451c7ad92178715c21d441825afd --- .../java/com/android/server/appop/AppOpsService.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/services/core/java/com/android/server/appop/AppOpsService.java b/services/core/java/com/android/server/appop/AppOpsService.java index 965a07b51e123..81ba4b813de1f 100644 --- a/services/core/java/com/android/server/appop/AppOpsService.java +++ b/services/core/java/com/android/server/appop/AppOpsService.java @@ -1548,19 +1548,20 @@ public class AppOpsService extends IAppOpsService.Stub { } private void enforceGetAppOpsStatsPermissionIfNeeded(int uid, String packageName) { - final int callingUid = Binder.getCallingUid(); // We get to access everything - if (callingUid == Process.myPid()) { + final int callingPid = Binder.getCallingPid(); + if (callingPid == Process.myPid()) { return; } // Apps can access their own data + final int callingUid = Binder.getCallingUid(); if (uid == callingUid && packageName != null && checkPackage(uid, packageName) == MODE_ALLOWED) { return; } // Otherwise, you need a permission... - mContext.enforcePermission(android.Manifest.permission.GET_APP_OPS_STATS, - Binder.getCallingPid(), callingUid, null); + mContext.enforcePermission(android.Manifest.permission.GET_APP_OPS_STATS, callingPid, + callingUid, null); } /**