From 0a8f05539bd951a1b3be432dc797986f629266cc Mon Sep 17 00:00:00 2001 From: Geoffrey Pitsch Date: Thu, 20 Apr 2017 13:56:40 -0400 Subject: [PATCH] Hide secondary text for Default channel if not blocked Secondary text was confusing to user. Test: runtest systemui Bug: 37509710 Change-Id: Ie4cf66c751b3b7b3943ca1c1ff557e8784ae39b0 --- .../com/android/systemui/statusbar/NotificationInfo.java | 4 +++- .../android/systemui/statusbar/NotificationInfoTest.java | 6 ++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/NotificationInfo.java b/packages/SystemUI/src/com/android/systemui/statusbar/NotificationInfo.java index 89251897e25f9..67057270d7505 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/NotificationInfo.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/NotificationInfo.java @@ -329,12 +329,14 @@ public class NotificationInfo extends LinearLayout implements NotificationGuts.G private void updateSecondaryText() { final boolean disabled = mSingleNotificationChannel != null && getSelectedImportance() == IMPORTANCE_NONE; + final boolean isDefaultChannel = mSingleNotificationChannel != null && + mSingleNotificationChannel.getId().equals(NotificationChannel.DEFAULT_CHANNEL_ID); if (disabled) { mChannelDisabledView.setVisibility(View.VISIBLE); mNumChannelsView.setVisibility(View.GONE); } else { mChannelDisabledView.setVisibility(View.GONE); - mNumChannelsView.setVisibility(View.VISIBLE); + mNumChannelsView.setVisibility(isDefaultChannel ? View.INVISIBLE : View.VISIBLE); } } diff --git a/packages/SystemUI/tests/src/com/android/systemui/statusbar/NotificationInfoTest.java b/packages/SystemUI/tests/src/com/android/systemui/statusbar/NotificationInfoTest.java index 66385a1dfb01e..907928f12a1c6 100644 --- a/packages/SystemUI/tests/src/com/android/systemui/statusbar/NotificationInfoTest.java +++ b/packages/SystemUI/tests/src/com/android/systemui/statusbar/NotificationInfoTest.java @@ -314,16 +314,14 @@ public class NotificationInfoTest extends SysuiTestCase { } @Test - public void testBindNotification_NumChannelsTextUniqueWhenDefaultChannel() throws Exception { + public void testBindNotification_NumChannelsTextHiddenWhenDefaultChannel() throws Exception { mNotificationInfo.bindNotification(mMockPackageManager, mMockINotificationManager, TEST_PACKAGE_NAME, Arrays.asList(mDefaultNotificationChannel), mNotificationChannel.getImportance(), mSbn, null, null, null, null, null); final TextView numChannelsView = (TextView) mNotificationInfo.findViewById(R.id.num_channels_desc); - assertEquals(View.VISIBLE, numChannelsView.getVisibility()); - assertEquals(mContext.getString(R.string.notification_default_channel_desc), - numChannelsView.getText()); + assertEquals(View.INVISIBLE, numChannelsView.getVisibility()); } @Test