From 7522e427380d9d93e9f72bbac40e4037f520532a Mon Sep 17 00:00:00 2001 From: Yohei Yukawa Date: Tue, 15 Feb 2022 16:15:29 +0000 Subject: [PATCH] Revert "Enable IMS#canImeRenderGesturalNavButtons() by default (2nd try)" This reverts commit f21d2115594e36b6ee290c4642b246eb776ae3cb [1]. Reason for revert: IME Nav buttons are unexpectedly invisible in the following cases. * work profile apps (Bug 219604375) * setup wizard (Bug 218322263) [1]: I39f454a2d41d7d5255b8cc4f7d9a3f7a7642b2f3 Bug: 215545985 Fix: 219604375 Test: Manually verified as follows. 1. Build aosp_coral-userdebug and flash it. 2. adb install -r TestDPC-normalv8001.apk 3. Set up work-profile 4. Enable gestural navigation mode 5. adb shell am start --user 10 -n \ com.android.documentsui/com.android.documentsui.files.FilesActivity 6. Tap the magnifier icon to show the AOSP Keyboard 7. Confirm that the back button is shown on the nav bar 8. adb shell dumpsys input_method | grep mNavigationBarController -> "No-op implementation" Change-Id: If3da8dbad0b8bd204cc4ec04f882e9248439c456 --- core/java/android/inputmethodservice/InputMethodService.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/java/android/inputmethodservice/InputMethodService.java b/core/java/android/inputmethodservice/InputMethodService.java index fc2fbc39dbebc..223b8ccf44c84 100644 --- a/core/java/android/inputmethodservice/InputMethodService.java +++ b/core/java/android/inputmethodservice/InputMethodService.java @@ -346,7 +346,7 @@ public class InputMethodService extends AbstractInputMethodService { */ @AnyThread public static boolean canImeRenderGesturalNavButtons() { - return SystemProperties.getBoolean(PROP_CAN_RENDER_GESTURAL_NAV_BUTTONS, true); + return SystemProperties.getBoolean(PROP_CAN_RENDER_GESTURAL_NAV_BUTTONS, false); } /**