From 345faf80152374131da793d60e578903741bc587 Mon Sep 17 00:00:00 2001 From: Miranda Kephart Date: Thu, 20 Oct 2022 12:43:03 -0400 Subject: [PATCH] Clean up ClipboardOverlayController after tests Bug: 254635291 Test: presubmits Change-Id: I39590542af188e3b5369e461fcba9a5b909b1ca7 --- .../clipboardoverlay/ClipboardOverlayController.java | 2 +- .../clipboardoverlay/ClipboardOverlayControllerTest.java | 8 ++++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/packages/SystemUI/src/com/android/systemui/clipboardoverlay/ClipboardOverlayController.java b/packages/SystemUI/src/com/android/systemui/clipboardoverlay/ClipboardOverlayController.java index bfb27a4c87b8e..9f338d1c6e1d8 100644 --- a/packages/SystemUI/src/com/android/systemui/clipboardoverlay/ClipboardOverlayController.java +++ b/packages/SystemUI/src/com/android/systemui/clipboardoverlay/ClipboardOverlayController.java @@ -459,7 +459,7 @@ public class ClipboardOverlayController implements ClipboardListener.ClipboardOv anim.start(); } - private void hideImmediate() { + void hideImmediate() { // Note this may be called multiple times if multiple dismissal events happen at the same // time. mTimeoutHandler.cancelTimeout(); diff --git a/packages/SystemUI/tests/src/com/android/systemui/clipboardoverlay/ClipboardOverlayControllerTest.java b/packages/SystemUI/tests/src/com/android/systemui/clipboardoverlay/ClipboardOverlayControllerTest.java index 677c7bdcffe17..b7f1c1a9f001e 100644 --- a/packages/SystemUI/tests/src/com/android/systemui/clipboardoverlay/ClipboardOverlayControllerTest.java +++ b/packages/SystemUI/tests/src/com/android/systemui/clipboardoverlay/ClipboardOverlayControllerTest.java @@ -39,8 +39,8 @@ import com.android.systemui.SysuiTestCase; import com.android.systemui.broadcast.BroadcastSender; import com.android.systemui.screenshot.TimeoutHandler; +import org.junit.After; import org.junit.Before; -import org.junit.Ignore; import org.junit.Test; import org.junit.runner.RunWith; import org.mockito.ArgumentCaptor; @@ -48,7 +48,6 @@ import org.mockito.Captor; import org.mockito.Mock; import org.mockito.MockitoAnnotations; -@Ignore("b/254635291") @SmallTest @RunWith(AndroidJUnit4.class) public class ClipboardOverlayControllerTest extends SysuiTestCase { @@ -97,6 +96,11 @@ public class ClipboardOverlayControllerTest extends SysuiTestCase { mCallbacks = mOverlayCallbacksCaptor.getValue(); } + @After + public void tearDown() { + mOverlayController.hideImmediate(); + } + @Test public void test_setClipData_nullData() { ClipData clipData = null;