From 7380c321ad23b6cbf0af239fbd2e037f67b08545 Mon Sep 17 00:00:00 2001 From: Jeff Sharkey Date: Mon, 27 Jun 2016 17:08:23 -0600 Subject: [PATCH] Remove "starting apps" boot message. The "starting apps" message is only shown for a short period of time before we show the lock screen. Recent boot animations now have a spin down phase which is just long enough to result in us flashing this message for a very short period of time, which looks janky. To avoid the janky behavior, remove this message altogether. Other boot messages for dexopt'ing after an OTA remain intact. Also fix security bug that would allow any app to show a message. Bug: 29367890 Change-Id: I77bb65acbe0e5afb4033dc6b83e533e665dce690 --- .../com/android/server/am/ActivityManagerService.java | 3 +-- services/java/com/android/server/SystemServer.java | 8 -------- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/services/core/java/com/android/server/am/ActivityManagerService.java b/services/core/java/com/android/server/am/ActivityManagerService.java index e5579e29c2089..9fcbf53e00808 100644 --- a/services/core/java/com/android/server/am/ActivityManagerService.java +++ b/services/core/java/com/android/server/am/ActivityManagerService.java @@ -6661,8 +6661,7 @@ public final class ActivityManagerService extends ActivityManagerNative @Override public void showBootMessage(final CharSequence msg, final boolean always) { if (Binder.getCallingUid() != Process.myUid()) { - // These days only the core system can call this, so apps can't get in - // the way of what we show about running them. + throw new SecurityException(); } mWindowManager.showBootMessage(msg, always); } diff --git a/services/java/com/android/server/SystemServer.java b/services/java/com/android/server/SystemServer.java index 76424d82a2b01..37a9d5df6237f 100644 --- a/services/java/com/android/server/SystemServer.java +++ b/services/java/com/android/server/SystemServer.java @@ -724,14 +724,6 @@ public final class SystemServer { } Trace.traceEnd(Trace.TRACE_TAG_SYSTEM_SERVER); - try { - ActivityManagerNative.getDefault().showBootMessage( - context.getResources().getText( - com.android.internal.R.string.android_upgrading_starting_apps), - false); - } catch (RemoteException e) { - } - if (mFactoryTestMode != FactoryTest.FACTORY_TEST_LOW_LEVEL) { if (!disableNonCoreServices) { traceBeginAndSlog("StartLockSettingsService");