Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Remove permission check in DevicePolicyManager.isUninstallBlocked()" into lmp-mr1-dev

Browse Source
This commit is contained in:
Rubin Xu
2014-11-18 23:43:14 +00:00
committed by Android (Google) Code Review
parent 3a7d3fc60e a97855b784
commit 735f22850e
2 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
core/java/android/app/admin/DevicePolicyManager.java
View File

@@ -3421,12 +3421,13 @@ public class DevicePolicyManager {
} }
/** /**
* Called by profile or device owners to check whether a user has been blocked from * Check whether the current user has been blocked by device policy from uninstalling a package.
* uninstalling a package. * Requires the caller to be the profile owner if checking a specific admin's policy.
* *
* @param admin Which {@link DeviceAdminReceiver} this request is associated with. * @param admin The name of the admin component whose blocking policy will be checked, or null
* to check if any admin has blocked the uninstallation.
* @param packageName package to check. * @param packageName package to check.
* @return true if the user shouldn't be able to uninstall the package. * @return true if uninstallation is blocked.
*/ */
public boolean isUninstallBlocked(ComponentName admin, String packageName) { public boolean isUninstallBlocked(ComponentName admin, String packageName) {
if (mService != null) { if (mService != null) {

8
services/devicepolicy/java/com/android/server/devicepolicy/DevicePolicyManagerService.java
View File

@@ -5040,13 +5040,15 @@ public class DevicePolicyManagerService extends IDevicePolicyManager.Stub {
@Override @Override
public boolean isUninstallBlocked(ComponentName who, String packageName) { public boolean isUninstallBlocked(ComponentName who, String packageName) {
// This function should return true if and only if the package is blocked by
// setUninstallBlocked(). It should still return false for other cases of blocks, such as
// when the package is a system app, or when it is an active device admin.
final int userId = UserHandle.getCallingUserId(); final int userId = UserHandle.getCallingUserId();
synchronized (this) { synchronized (this) {
if (who == null) { if (who != null) {
throw new NullPointerException("ComponentName is null"); getActiveAdminForCallerLocked(who, DeviceAdminInfo.USES_POLICY_PROFILE_OWNER);
} }
getActiveAdminForCallerLocked(who, DeviceAdminInfo.USES_POLICY_PROFILE_OWNER);
long id = Binder.clearCallingIdentity(); long id = Binder.clearCallingIdentity();
try { try {