From 1925e290e7ac2801311cb4e732d1bc5a5f3e0c44 Mon Sep 17 00:00:00 2001 From: Victoria Lease Date: Mon, 24 Sep 2012 17:00:18 -0700 Subject: [PATCH] getBestProvider() prefers GPS over NLP Preferring the GPS location provider over NLP should produce better average and worst-case results than NLP, which is very accurate in certain conditions and completely useless in others. Bug: 7182301 Change-Id: If7d50f0d3ac663cbfd84b7033adc204c11bcaca4 --- .../java/com/android/server/LocationManagerService.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/services/java/com/android/server/LocationManagerService.java b/services/java/com/android/server/LocationManagerService.java index 197f6ab638606..05d11b928ad90 100644 --- a/services/java/com/android/server/LocationManagerService.java +++ b/services/java/com/android/server/LocationManagerService.java @@ -687,10 +687,10 @@ public class LocationManagerService extends ILocationManager.Stub implements Run } private String pickBest(List providers) { - if (providers.contains(LocationManager.NETWORK_PROVIDER)) { - return LocationManager.NETWORK_PROVIDER; - } else if (providers.contains(LocationManager.GPS_PROVIDER)) { + if (providers.contains(LocationManager.GPS_PROVIDER)) { return LocationManager.GPS_PROVIDER; + } else if (providers.contains(LocationManager.NETWORK_PROVIDER)) { + return LocationManager.NETWORK_PROVIDER; } else { return providers.get(0); }