diff --git a/core/jni/android_os_HwRemoteBinder.cpp b/core/jni/android_os_HwRemoteBinder.cpp index ca5e1e45dcdc9..f8f841c6fd26d 100644 --- a/core/jni/android_os_HwRemoteBinder.cpp +++ b/core/jni/android_os_HwRemoteBinder.cpp @@ -189,8 +189,7 @@ void HwBinderDeathRecipientList::add(const sp& recipient void HwBinderDeathRecipientList::remove(const sp& recipient) { AutoMutex _l(mLock); - List< sp >::iterator iter; - for (iter = mList.begin(); iter != mList.end(); iter++) { + for (auto iter = mList.begin(); iter != mList.end(); iter++) { if (*iter == recipient) { mList.erase(iter); return; @@ -201,12 +200,13 @@ void HwBinderDeathRecipientList::remove(const sp& recipi sp HwBinderDeathRecipientList::find(jobject recipient) { AutoMutex _l(mLock); - for (const sp& deathRecipient : mList) { - if (deathRecipient->matches(recipient)) { - return deathRecipient; + for(auto iter = mList.rbegin(); iter != mList.rend(); iter++) { + if ((*iter)->matches(recipient)) { + return (*iter); } } - return NULL; + + return nullptr; } Mutex& HwBinderDeathRecipientList::lock() { diff --git a/core/jni/android_os_HwRemoteBinder.h b/core/jni/android_os_HwRemoteBinder.h index 63aad0ab2923b..4b5a4c8c837c7 100644 --- a/core/jni/android_os_HwRemoteBinder.h +++ b/core/jni/android_os_HwRemoteBinder.h @@ -20,9 +20,9 @@ #include #include #include -#include #include #include +#include namespace android { @@ -33,7 +33,7 @@ namespace android { class HwBinderDeathRecipient; class HwBinderDeathRecipientList : public RefBase { - List< sp > mList; + std::vector> mList; Mutex mLock; public: @@ -42,6 +42,8 @@ public: void add(const sp& recipient); void remove(const sp& recipient); + + // finds the most recently added matching death recipient sp find(jobject recipient); Mutex& lock(); // Use with care; specifically for mutual exclusion during binder death