From 6568cf185de1f540e87b827966dc09a268bf77a6 Mon Sep 17 00:00:00 2001 From: Chad Brubaker Date: Tue, 8 Dec 2015 13:37:28 -0800 Subject: [PATCH] Refactor NetworkSecurityPolicy to be pluggable This allows us to keep the logic for the NetworkSecurityPolicy in the framework instead of in libcore. Change-Id: I4bf494f79c27729cb17d93d90a91319492270ce9 --- .../FrameworkNetworkSecurityPolicy.java | 35 +++++++++++++++++++ .../security/NetworkSecurityPolicy.java | 5 +-- 2 files changed, 38 insertions(+), 2 deletions(-) create mode 100644 core/java/android/security/FrameworkNetworkSecurityPolicy.java diff --git a/core/java/android/security/FrameworkNetworkSecurityPolicy.java b/core/java/android/security/FrameworkNetworkSecurityPolicy.java new file mode 100644 index 0000000000000..e3dac5ee4a5ec --- /dev/null +++ b/core/java/android/security/FrameworkNetworkSecurityPolicy.java @@ -0,0 +1,35 @@ +/** + * Copyright (c) 2015, The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package android.security; + +/** + * Android framework's implementation of {@link libcore.net.NetworkSecurityPolicy}. + * + * @hide + */ +public class FrameworkNetworkSecurityPolicy extends libcore.net.NetworkSecurityPolicy { + private final boolean mCleartextTrafficPermitted; + + public FrameworkNetworkSecurityPolicy(boolean cleartextTrafficPermitted) { + mCleartextTrafficPermitted = cleartextTrafficPermitted; + } + + @Override + public boolean isCleartextTrafficPermitted() { + return mCleartextTrafficPermitted; + } +} diff --git a/core/java/android/security/NetworkSecurityPolicy.java b/core/java/android/security/NetworkSecurityPolicy.java index 7e8771707b701..7991d373b49f9 100644 --- a/core/java/android/security/NetworkSecurityPolicy.java +++ b/core/java/android/security/NetworkSecurityPolicy.java @@ -60,7 +60,7 @@ public class NetworkSecurityPolicy { *

NOTE: {@link android.webkit.WebView} does not honor this flag. */ public boolean isCleartextTrafficPermitted() { - return libcore.net.NetworkSecurityPolicy.isCleartextTrafficPermitted(); + return libcore.net.NetworkSecurityPolicy.getInstance().isCleartextTrafficPermitted(); } /** @@ -72,6 +72,7 @@ public class NetworkSecurityPolicy { * @hide */ public void setCleartextTrafficPermitted(boolean permitted) { - libcore.net.NetworkSecurityPolicy.setCleartextTrafficPermitted(permitted); + FrameworkNetworkSecurityPolicy policy = new FrameworkNetworkSecurityPolicy(permitted); + libcore.net.NetworkSecurityPolicy.setInstance(policy); } }