Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge change 24742 into eclair

Browse Source 
* changes:
  Apparently I must not use OMX_UseBuffer on either input or output ports on any of the TI components... or else.
This commit is contained in:
Android (Google) Code Review
2009-09-14 13:08:02 -04:00
parent 0fdae4cc74 2dc64d80e3
commit 714ec1360c
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
media/libstagefright/OMXCodec.cpp
View File

@@ -232,6 +232,16 @@ sp<OMXCodec> OMXCodec::Create(
quirks |= kRequiresAllocateBufferOnOutputPorts; quirks |= kRequiresAllocateBufferOnOutputPorts;
} }
if (!strncmp(componentName, "OMX.TI.", 7)) {
// Apparently I must not use OMX_UseBuffer on either input or
// output ports on any of the TI components or quote:
// "(I) may have unexpected problem (sic) which can be timing related
// and hard to reproduce."
quirks |= kRequiresAllocateBufferOnInputPorts;
quirks |= kRequiresAllocateBufferOnOutputPorts;
}
sp<OMXCodec> codec = new OMXCodec( sp<OMXCodec> codec = new OMXCodec(
omx, node, quirks, createEncoder, mime, componentName, omx, node, quirks, createEncoder, mime, componentName,
source); source);
@@ -840,8 +850,8 @@ status_t OMXCodec::allocateBuffersOnPort(OMX_U32 portIndex) {
mNode, portIndex, mem, &buffer); mNode, portIndex, mem, &buffer);
} else if (portIndex == kPortIndexOutput } else if (portIndex == kPortIndexOutput
&& (mQuirks & kRequiresAllocateBufferOnOutputPorts)) { && (mQuirks & kRequiresAllocateBufferOnOutputPorts)) {
err = mOMX->allocate_buffer( err = mOMX->allocate_buffer_with_backup(
mNode, portIndex, def.nBufferSize, &buffer); mNode, portIndex, mem, &buffer);
} else { } else {
err = mOMX->use_buffer(mNode, portIndex, mem, &buffer); err = mOMX->use_buffer(mNode, portIndex, mem, &buffer);
} }