Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Only allow access to the dexopt commands from root or shell." into udc-dev

Browse Source
This commit is contained in:
Martin Stjernholm
2023-02-27 20:44:36 +00:00
committed by Android (Google) Code Review
parent 48df60223c 8b7f36afec
commit 71498b565e
2 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
services/core/java/com/android/server/pm/PackageManagerService.java
View File

@@ -6675,15 +6675,7 @@ public class PackageManagerService implements PackageSender, TestUtilityService
@Deprecated @Deprecated
public void legacyDumpProfiles(String packageName, boolean dumpClassesAndMethods) public void legacyDumpProfiles(String packageName, boolean dumpClassesAndMethods)
throws LegacyDexoptDisabledException { throws LegacyDexoptDisabledException {
/* Only the shell, root, or the app user should be able to dump profiles. */
final int callingUid = Binder.getCallingUid();
final Computer snapshot = snapshotComputer(); final Computer snapshot = snapshotComputer();
final String[] callerPackageNames = snapshot.getPackagesForUid(callingUid);
if (!PackageManagerServiceUtils.isRootOrShell(callingUid)
&& !ArrayUtils.contains(callerPackageNames, packageName)) {
throw new SecurityException("dumpProfiles");
}
AndroidPackage pkg = snapshot.getPackage(packageName); AndroidPackage pkg = snapshot.getPackage(packageName);
if (pkg == null) { if (pkg == null) {
throw new IllegalArgumentException("Unknown package: " + packageName); throw new IllegalArgumentException("Unknown package: " + packageName);

5
services/core/java/com/android/server/pm/PackageManagerShellCommand.java
View File

@@ -391,6 +391,11 @@ class PackageManagerShellCommand extends ShellCommand {
private int runLegacyDexoptCommand(@NonNull String cmd) private int runLegacyDexoptCommand(@NonNull String cmd)
throws RemoteException, LegacyDexoptDisabledException { throws RemoteException, LegacyDexoptDisabledException {
Installer.checkLegacyDexoptDisabled(); Installer.checkLegacyDexoptDisabled();
if (!PackageManagerServiceUtils.isRootOrShell(Binder.getCallingUid())) {
throw new SecurityException("Dexopt shell commands need root or shell access");
}
switch (cmd) { switch (cmd) {
case "compile": case "compile":
return runCompile(); return runCompile();