From 5dea7d554a6c9655ad2b578f900fe8840c86934b Mon Sep 17 00:00:00 2001 From: Jeff Sharkey Date: Tue, 3 Sep 2013 12:01:20 -0700 Subject: [PATCH] Skip packages with missing metadata. Otherwise this would result in NPE, and packages.list would never be updated. Bug: 10577538 Change-Id: I35a4407dbc283ab20a4c45a2ea1a14b04044c98c --- services/java/com/android/server/pm/Settings.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/services/java/com/android/server/pm/Settings.java b/services/java/com/android/server/pm/Settings.java index ff1128dbacdfa..415cda19ecf29 100644 --- a/services/java/com/android/server/pm/Settings.java +++ b/services/java/com/android/server/pm/Settings.java @@ -1385,6 +1385,11 @@ final class Settings { StringBuilder sb = new StringBuilder(); for (final PackageSetting pkg : mPackages.values()) { + if (pkg.pkg == null || pkg.pkg.applicationInfo == null) { + Slog.w(TAG, "Skipping " + pkg + " due to missing metadata"); + continue; + } + final ApplicationInfo ai = pkg.pkg.applicationInfo; final String dataPath = ai.dataDir; final boolean isDebug = (ai.flags & ApplicationInfo.FLAG_DEBUGGABLE) != 0;