From 6fcf0eb913d686979297102a9aa4da1214d85fb3 Mon Sep 17 00:00:00 2001 From: Jeff DeCew Date: Tue, 9 May 2023 13:24:25 -0400 Subject: [PATCH] Use android.icu.text.SimpleDateFormat to speed up LogBuffer dumping Fixes: 281693061 Test: dumpsysui buffers Change-Id: I5e00bbb78ef8a0d14fc813afb9fb17950f743618 --- .../SystemUI/log/src/com/android/systemui/log/LogMessage.kt | 2 +- .../src/com/android/systemui/dump/LogBufferEulogizer.kt | 2 +- .../src/com/android/systemui/log/table/TableLogBuffer.kt | 2 +- .../src/com/android/systemui/privacy/logging/PrivacyLogger.kt | 2 +- .../src/com/android/systemui/shade/NPVCDownEventState.kt | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/SystemUI/log/src/com/android/systemui/log/LogMessage.kt b/packages/SystemUI/log/src/com/android/systemui/log/LogMessage.kt index 88c34f82a0891..8c3988b027feb 100644 --- a/packages/SystemUI/log/src/com/android/systemui/log/LogMessage.kt +++ b/packages/SystemUI/log/src/com/android/systemui/log/LogMessage.kt @@ -16,8 +16,8 @@ package com.android.systemui.log +import android.icu.text.SimpleDateFormat import java.io.PrintWriter -import java.text.SimpleDateFormat import java.util.Locale /** diff --git a/packages/SystemUI/src/com/android/systemui/dump/LogBufferEulogizer.kt b/packages/SystemUI/src/com/android/systemui/dump/LogBufferEulogizer.kt index 0eab1afc41197..2d5c9ae2e641b 100644 --- a/packages/SystemUI/src/com/android/systemui/dump/LogBufferEulogizer.kt +++ b/packages/SystemUI/src/com/android/systemui/dump/LogBufferEulogizer.kt @@ -17,6 +17,7 @@ package com.android.systemui.dump import android.content.Context +import android.icu.text.SimpleDateFormat import android.util.Log import com.android.systemui.dagger.SysUISingleton import com.android.systemui.log.LogBuffer @@ -30,7 +31,6 @@ import java.nio.file.Paths import java.nio.file.StandardOpenOption.CREATE import java.nio.file.StandardOpenOption.TRUNCATE_EXISTING import java.nio.file.attribute.BasicFileAttributes -import java.text.SimpleDateFormat import java.util.Locale import java.util.concurrent.TimeUnit import javax.inject.Inject diff --git a/packages/SystemUI/src/com/android/systemui/log/table/TableLogBuffer.kt b/packages/SystemUI/src/com/android/systemui/log/table/TableLogBuffer.kt index 1d785ae62d873..cabe319d317da 100644 --- a/packages/SystemUI/src/com/android/systemui/log/table/TableLogBuffer.kt +++ b/packages/SystemUI/src/com/android/systemui/log/table/TableLogBuffer.kt @@ -16,6 +16,7 @@ package com.android.systemui.log.table +import android.icu.text.SimpleDateFormat import android.os.Trace import com.android.systemui.Dumpable import com.android.systemui.common.buffer.RingBuffer @@ -24,7 +25,6 @@ import com.android.systemui.log.LogLevel import com.android.systemui.log.LogcatEchoTracker import com.android.systemui.util.time.SystemClock import java.io.PrintWriter -import java.text.SimpleDateFormat import java.util.Locale import kotlinx.coroutines.CoroutineDispatcher import kotlinx.coroutines.CoroutineScope diff --git a/packages/SystemUI/src/com/android/systemui/privacy/logging/PrivacyLogger.kt b/packages/SystemUI/src/com/android/systemui/privacy/logging/PrivacyLogger.kt index f9e1adff012bf..e56106d1c065b 100644 --- a/packages/SystemUI/src/com/android/systemui/privacy/logging/PrivacyLogger.kt +++ b/packages/SystemUI/src/com/android/systemui/privacy/logging/PrivacyLogger.kt @@ -16,6 +16,7 @@ package com.android.systemui.privacy.logging +import android.icu.text.SimpleDateFormat import android.permission.PermissionGroupUsage import com.android.systemui.log.dagger.PrivacyLog import com.android.systemui.log.LogBuffer @@ -23,7 +24,6 @@ import com.android.systemui.log.LogLevel import com.android.systemui.log.LogMessage import com.android.systemui.privacy.PrivacyDialog import com.android.systemui.privacy.PrivacyItem -import java.text.SimpleDateFormat import java.util.Locale import javax.inject.Inject diff --git a/packages/SystemUI/src/com/android/systemui/shade/NPVCDownEventState.kt b/packages/SystemUI/src/com/android/systemui/shade/NPVCDownEventState.kt index b8bd95c89ec8a..6143308a7cbf4 100644 --- a/packages/SystemUI/src/com/android/systemui/shade/NPVCDownEventState.kt +++ b/packages/SystemUI/src/com/android/systemui/shade/NPVCDownEventState.kt @@ -13,11 +13,11 @@ */ package com.android.systemui.shade +import android.icu.text.SimpleDateFormat import android.view.MotionEvent import com.android.systemui.common.buffer.RingBuffer import com.android.systemui.dump.DumpsysTableLogger import com.android.systemui.dump.Row -import java.text.SimpleDateFormat import java.util.Locale /** Container for storing information about [MotionEvent.ACTION_DOWN] on