From 6f89fa07b4105b2e0cfac87db7ce5e7c9b9feead Mon Sep 17 00:00:00 2001 From: Kenny Root Date: Fri, 30 Jul 2010 16:33:47 -0700 Subject: [PATCH] Only install after MCS success If MCS dies in the middle of a call during install, only proceed if the call was successful. Otherwise wait for the max retries to be reached and run the failure handling code there. Change-Id: I00a27ea91046ea6521a3cff5e5ffe2c71b2b5bb4 --- .../java/com/android/server/PackageManagerService.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/services/java/com/android/server/PackageManagerService.java b/services/java/com/android/server/PackageManagerService.java index b29c6e6832220..ff4ff7422b970 100644 --- a/services/java/com/android/server/PackageManagerService.java +++ b/services/java/com/android/server/PackageManagerService.java @@ -5019,7 +5019,12 @@ class PackageManagerService extends IPackageManager.Stub { @Override void handleReturnCode() { - processPendingInstall(mArgs, mRet); + // If mArgs is null, then MCS couldn't be reached. When it + // reconnects, it will try again to install. At that point, this + // will succeed. + if (mArgs != null) { + processPendingInstall(mArgs, mRet); + } } @Override