Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Make sure to call back View#onCheckIsTextEditor() on the UI thread" into udc-dev

Browse Source
This commit is contained in:
Treehugger Robot
2023-06-29 17:38:57 +00:00
committed by Android (Google) Code Review
parent 9a2a683a56 e92f5e8c2b
commit 6e1bc14f58
1 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
core/java/android/view/inputmethod/InputMethodManager.java
View File

@@ -2657,17 +2657,6 @@ public final class InputMethodManager {
} }
} }
if (windowGainingFocus == null) {
windowGainingFocus = view.getWindowToken();
if (windowGainingFocus == null) {
Log.e(TAG, "ABORT input: ServedView must be attached to a Window");
return false;
}
startInputFlags = getStartInputFlags(view, startInputFlags);
softInputMode = view.getViewRootImpl().mWindowAttributes.softInputMode;
windowFlags = view.getViewRootImpl().mWindowAttributes.flags;
}
// Now we need to get an input connection from the served view. // Now we need to get an input connection from the served view.
// This is complicated in a couple ways: we can't be holding our lock // This is complicated in a couple ways: we can't be holding our lock
// when calling out to the view, and we need to make sure we call into // when calling out to the view, and we need to make sure we call into
@@ -2690,6 +2679,17 @@ public final class InputMethodManager {
return false; return false;
} }
if (windowGainingFocus == null) {
windowGainingFocus = view.getWindowToken();
if (windowGainingFocus == null) {
Log.e(TAG, "ABORT input: ServedView must be attached to a Window");
return false;
}
startInputFlags = getStartInputFlags(view, startInputFlags);
softInputMode = view.getViewRootImpl().mWindowAttributes.softInputMode;
windowFlags = view.getViewRootImpl().mWindowAttributes.flags;
}
// Okay we are now ready to call into the served view and have it // Okay we are now ready to call into the served view and have it
// do its stuff. // do its stuff.
// Life is good: let's hook everything up! // Life is good: let's hook everything up!