From 1c07ebb6513f00525756ba95de77c72cd35bf5bb Mon Sep 17 00:00:00 2001 From: Karl Rosaen Date: Wed, 22 Jul 2009 10:11:00 -0700 Subject: [PATCH] Proactively set mVisible attribute in startSearch and stopSearch (not just in message handler). This way someone can call searchManger.startSearch() and immediately have searchManger.isVisible() reflect the correct value. Fixes failing tests and bug 1993675 --- core/java/android/server/search/SearchDialogWrapper.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/core/java/android/server/search/SearchDialogWrapper.java b/core/java/android/server/search/SearchDialogWrapper.java index d3ef5de8634fb..b8a9875605c8a 100644 --- a/core/java/android/server/search/SearchDialogWrapper.java +++ b/core/java/android/server/search/SearchDialogWrapper.java @@ -190,6 +190,9 @@ implements DialogInterface.OnCancelListener, DialogInterface.OnDismissListener { msgData.putBundle(KEY_APP_SEARCH_DATA, appSearchData); msgData.putInt(KEY_IDENT, ident); mSearchUiThread.sendMessage(msg); + // be a little more eager in setting this so isVisible will return the correct value if + // called immediately after startSearch + mVisible = true; } /** @@ -199,6 +202,9 @@ implements DialogInterface.OnCancelListener, DialogInterface.OnDismissListener { public void stopSearch() { if (DBG) debug("stopSearch()"); mSearchUiThread.sendEmptyMessage(MSG_STOP_SEARCH); + // be a little more eager in setting this so isVisible will return the correct value if + // called immediately after stopSearch + mVisible = false; } /**