Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

am 5b48223d: Merge change I14e833fa into eclair

Browse Source 
Merge commit '5b48223d0e8b8becea0c120895d964e6472b3552' into eclair-mr2

* commit '5b48223d0e8b8becea0c120895d964e6472b3552':
  If we fail to persist the current settings and fall back to the back settings file
This commit is contained in:
Suchi Amalapurapu
2009-10-22 06:38:33 -07:00
committed by Android Git Automerger
parent 0b3977f87b 5b48223d0e
commit 6d924c69af
1 changed files with 18 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
services/java/com/android/server/PackageManagerService.java
View File

@@ -6440,12 +6440,17 @@ class PackageManagerService extends IPackageManager.Stub {
// Keep the old settings around until we know the new ones have
// been successfully written.
if (mSettingsFilename.exists()) {
if (mBackupSettingsFilename.exists()) {
mBackupSettingsFilename.delete();
}
if (!mSettingsFilename.renameTo(mBackupSettingsFilename)) {
Log.w(TAG, "Unable to backup package manager settings, current changes will be lost at reboot");
return;
// Presence of backup settings file indicates that we failed
// to persist settings earlier. So preserve the older
// backup for future reference since the current settings
// might have been corrupted.
if (!mBackupSettingsFilename.exists()) {
if (!mSettingsFilename.renameTo(mBackupSettingsFilename)) {
Log.w(TAG, "Unable to backup package manager settings, current changes will be lost at reboot");
return;
}
} else {
Log.w(TAG, "Preserving older settings backup");
}
}
@@ -6712,6 +6717,13 @@ class PackageManagerService extends IPackageManager.Stub {
str = new FileInputStream(mBackupSettingsFilename);
mReadMessages.append("Reading from backup settings file\n");
Log.i(TAG, "Reading from backup settings file!");
if (mSettingsFilename.exists()) {
// If both the backup and settings file exist, we
// ignore the settings since it might have been
// corrupted.
Log.w(TAG, "Cleaning up settings file " + mSettingsFilename);
mSettingsFilename.delete();
}
} catch (java.io.IOException e) {
// We'll try for the normal settings file.
}