From 92a5be96d8af6a47e31b8db9467123292ea73fb0 Mon Sep 17 00:00:00 2001 From: alanv Date: Thu, 9 Aug 2012 17:47:09 -0700 Subject: [PATCH] Reload page when A11y is on and the JavaScript state changes. Bug: 6910403 Change-Id: I0965d76e76282736d053947eb96be0af32fd6001 --- .../android/webkit/AccessibilityInjector.java | 18 ++++++++++++++++++ .../android/webkit/WebSettingsClassic.java | 1 + core/java/android/webkit/WebViewClassic.java | 6 ++++++ 3 files changed, 25 insertions(+) diff --git a/core/java/android/webkit/AccessibilityInjector.java b/core/java/android/webkit/AccessibilityInjector.java index 7dfb5bb102e2a..fd73fdaa03e2d 100644 --- a/core/java/android/webkit/AccessibilityInjector.java +++ b/core/java/android/webkit/AccessibilityInjector.java @@ -279,6 +279,7 @@ class AccessibilityInjector { } if (!shouldInjectJavaScript(url)) { + mAccessibilityScriptInjected = false; toggleFallbackAccessibilityInjector(true); return; } @@ -291,6 +292,23 @@ class AccessibilityInjector { mAccessibilityScriptInjected = true; } + /** + * Adjusts the accessibility injection state to reflect changes in the + * JavaScript enabled state. + * + * @param enabled Whether JavaScript is enabled. + */ + public void updateJavaScriptEnabled(boolean enabled) { + if (enabled) { + addAccessibilityApisIfNecessary(); + } else { + removeAccessibilityApisIfNecessary(); + } + + // We have to reload the page after adding or removing APIs. + mWebView.reload(); + } + /** * Toggles the non-JavaScript method for handling accessibility. * diff --git a/core/java/android/webkit/WebSettingsClassic.java b/core/java/android/webkit/WebSettingsClassic.java index 66651f7be2a36..1be917e4ef9cb 100644 --- a/core/java/android/webkit/WebSettingsClassic.java +++ b/core/java/android/webkit/WebSettingsClassic.java @@ -1135,6 +1135,7 @@ public class WebSettingsClassic extends WebSettings { if (mJavaScriptEnabled != flag) { mJavaScriptEnabled = flag; postSync(); + mWebView.updateJavaScriptEnabled(flag); } } diff --git a/core/java/android/webkit/WebViewClassic.java b/core/java/android/webkit/WebViewClassic.java index 5b8764bbae746..fa2203180e9a1 100644 --- a/core/java/android/webkit/WebViewClassic.java +++ b/core/java/android/webkit/WebViewClassic.java @@ -1630,6 +1630,12 @@ public final class WebViewClassic implements WebViewProvider, WebViewProvider.Sc mZoomManager.updateMultiTouchSupport(context); } + void updateJavaScriptEnabled(boolean enabled) { + if (isAccessibilityEnabled()) { + getAccessibilityInjector().updateJavaScriptEnabled(enabled); + } + } + private void init() { OnTrimMemoryListener.init(mContext); mWebView.setWillNotDraw(false);