Merge "Apply correct bottom padding to layouts" into nyc-dev

This commit is contained in:
Raph Levien
2016-04-06 15:52:54 +00:00
committed by Android (Google) Code Review
2 changed files with 4 additions and 14 deletions

View File

@@ -183,8 +183,10 @@ public class BoringLayout extends Layout implements TextUtils.EllipsizeCallback
if (includepad) { if (includepad) {
spacing = metrics.bottom - metrics.top; spacing = metrics.bottom - metrics.top;
mDesc = metrics.bottom;
} else { } else {
spacing = metrics.descent - metrics.ascent; spacing = metrics.descent - metrics.ascent;
mDesc = metrics.descent;
} }
mBottom = spacing; mBottom = spacing;
@@ -208,8 +210,6 @@ public class BoringLayout extends Layout implements TextUtils.EllipsizeCallback
mTopPadding = metrics.top - metrics.ascent; mTopPadding = metrics.top - metrics.ascent;
mBottomPadding = metrics.bottom - metrics.descent; mBottomPadding = metrics.bottom - metrics.descent;
} }
mDesc = spacing + mBottomPadding + (includepad ? metrics.top : metrics.ascent);
} }
/** /**

View File

@@ -1132,22 +1132,12 @@ public class StaticLayout extends Layout {
@Override @Override
public int getLineTop(int line) { public int getLineTop(int line) {
int top = mLines[mColumns * line + TOP]; return mLines[mColumns * line + TOP];
if (mMaximumVisibleLineCount > 0 && line >= mMaximumVisibleLineCount &&
line != mLineCount) {
top += getBottomPadding();
}
return top;
} }
@Override @Override
public int getLineDescent(int line) { public int getLineDescent(int line) {
int descent = mLines[mColumns * line + DESCENT]; return mLines[mColumns * line + DESCENT];
if (mMaximumVisibleLineCount > 0 && line >= mMaximumVisibleLineCount - 1 && // -1 intended
line != mLineCount) {
descent += getBottomPadding();
}
return descent;
} }
@Override @Override