Prevent non-admin users from deleting system apps.
This addresses a security issue where the guest user can remove updates for system apps. With this CL, attempts to uninstall/downgrade system apps will fail if attempted by a non-admin user. This is a backport of ag/17352264. Bug: 170646036 Test: manual, try uninstalling system app update as guest Change-Id: I79c3bf303e729e00d8fb12c40330bc10c5ffec6e Merged-In: I4e959e296cca9bbdfc8fccc5e5e0e654ca524165
This commit is contained in:
@@ -18529,6 +18529,16 @@ public class PackageManagerService extends IPackageManager.Stub
|
|||||||
return PackageManager.DELETE_FAILED_INTERNAL_ERROR;
|
return PackageManager.DELETE_FAILED_INTERNAL_ERROR;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if (isSystemApp(uninstalledPs)) {
|
||||||
|
UserInfo userInfo = mUserManager.getUserInfo(userId);
|
||||||
|
if (userInfo == null || !userInfo.isAdmin()) {
|
||||||
|
Slog.w(TAG, "Not removing package " + packageName
|
||||||
|
+ " as only admin user may downgrade system apps");
|
||||||
|
EventLog.writeEvent(0x534e4554, "170646036", -1, packageName);
|
||||||
|
return PackageManager.DELETE_FAILED_USER_RESTRICTED;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
disabledSystemPs = mSettings.getDisabledSystemPkgLPr(packageName);
|
disabledSystemPs = mSettings.getDisabledSystemPkgLPr(packageName);
|
||||||
// Save the enabled state before we delete the package. When deleting a stub
|
// Save the enabled state before we delete the package. When deleting a stub
|
||||||
// application we always set the enabled state to 'disabled'.
|
// application we always set the enabled state to 'disabled'.
|
||||||
|
|||||||
Reference in New Issue
Block a user