From e9ab2687dac8eaff0d37572dd7b49687a65dae3b Mon Sep 17 00:00:00 2001 From: Beverly Date: Fri, 18 Sep 2020 15:46:21 -0400 Subject: [PATCH] Add debugging logs for Doze Test: manual Bug: 168778910 Change-Id: If6c89df1a426fb2f15abf1d53567b5a72d4aab5f --- .../src/com/android/systemui/doze/DozeLog.java | 16 ++++++++++++++++ .../src/com/android/systemui/doze/DozeLogger.kt | 16 ++++++++++++++++ .../com/android/systemui/doze/DozeMachine.java | 2 ++ .../systemui/doze/DozeScreenBrightness.java | 6 ++++++ .../util/sensors/ThresholdSensorImpl.java | 2 +- 5 files changed, 41 insertions(+), 1 deletion(-) diff --git a/packages/SystemUI/src/com/android/systemui/doze/DozeLog.java b/packages/SystemUI/src/com/android/systemui/doze/DozeLog.java index 424a8246b2786..6154a4ecb85cc 100644 --- a/packages/SystemUI/src/com/android/systemui/doze/DozeLog.java +++ b/packages/SystemUI/src/com/android/systemui/doze/DozeLog.java @@ -197,6 +197,22 @@ public class DozeLog implements Dumpable { mLogger.logDozeStateChanged(state); } + /** + * Appends doze state changed sent to all DozeMachine parts event to the logs + * @param state new DozeMachine state + */ + public void traceDozeStateSendComplete(DozeMachine.State state) { + mLogger.logStateChangedSent(state); + } + + /** + * Appends display state changed event to the logs + * @param displayState new DozeMachine state + */ + public void traceDisplayState(int displayState) { + mLogger.logDisplayStateChanged(displayState); + } + /** * Appends wake-display event to the logs. * @param wake if we're waking up or sleeping. diff --git a/packages/SystemUI/src/com/android/systemui/doze/DozeLogger.kt b/packages/SystemUI/src/com/android/systemui/doze/DozeLogger.kt index 732745a1158b5..46cec95a967a0 100644 --- a/packages/SystemUI/src/com/android/systemui/doze/DozeLogger.kt +++ b/packages/SystemUI/src/com/android/systemui/doze/DozeLogger.kt @@ -143,6 +143,22 @@ class DozeLogger @Inject constructor( }) } + fun logStateChangedSent(state: DozeMachine.State) { + buffer.log(TAG, INFO, { + str1 = state.name + }, { + "Doze state sent to all DozeMachineParts stateSent=$str1" + }) + } + + fun logDisplayStateChanged(displayState: Int) { + buffer.log(TAG, INFO, { + int1 = displayState + }, { + "Display state changed to $int1" + }) + } + fun logWakeDisplay(isAwake: Boolean) { buffer.log(TAG, DEBUG, { bool1 = isAwake diff --git a/packages/SystemUI/src/com/android/systemui/doze/DozeMachine.java b/packages/SystemUI/src/com/android/systemui/doze/DozeMachine.java index d5820f3e05e4f..1e0460bea5be6 100644 --- a/packages/SystemUI/src/com/android/systemui/doze/DozeMachine.java +++ b/packages/SystemUI/src/com/android/systemui/doze/DozeMachine.java @@ -205,6 +205,7 @@ public class DozeMachine { } void onScreenState(int state) { + mDozeLog.traceDisplayState(state); for (Part part : mParts) { part.onScreenState(state); } @@ -308,6 +309,7 @@ public class DozeMachine { for (Part p : mParts) { p.transitionTo(oldState, newState); } + mDozeLog.traceDozeStateSendComplete(newState); switch (newState) { case FINISH: diff --git a/packages/SystemUI/src/com/android/systemui/doze/DozeScreenBrightness.java b/packages/SystemUI/src/com/android/systemui/doze/DozeScreenBrightness.java index 5aeb8df2028dd..92494cf5b5469 100644 --- a/packages/SystemUI/src/com/android/systemui/doze/DozeScreenBrightness.java +++ b/packages/SystemUI/src/com/android/systemui/doze/DozeScreenBrightness.java @@ -35,6 +35,7 @@ import com.android.systemui.doze.dagger.DozeScope; import com.android.systemui.doze.dagger.WrappedService; import com.android.systemui.util.sensors.AsyncSensorManager; +import java.io.PrintWriter; import java.util.Optional; import javax.inject.Inject; @@ -221,4 +222,9 @@ public class DozeScreenBrightness extends BroadcastReceiver implements DozeMachi mDebugBrightnessBucket = intent.getIntExtra(BRIGHTNESS_BUCKET, -1); updateBrightnessAndReady(false /* force */); } + + /** Dump current state */ + public void dump(PrintWriter pw) { + pw.println("DozeScreenBrightnessSensorRegistered=" + mRegistered); + } } diff --git a/packages/SystemUI/src/com/android/systemui/util/sensors/ThresholdSensorImpl.java b/packages/SystemUI/src/com/android/systemui/util/sensors/ThresholdSensorImpl.java index aa50292edbf72..71b255229c8f7 100644 --- a/packages/SystemUI/src/com/android/systemui/util/sensors/ThresholdSensorImpl.java +++ b/packages/SystemUI/src/com/android/systemui/util/sensors/ThresholdSensorImpl.java @@ -199,7 +199,7 @@ class ThresholdSensorImpl implements ThresholdSensor { @Override public String toString() { - return String.format("{registered=%s, paused=%s, threshold=%s, sensor=%s}", + return String.format("{isLoaded=%s, registered=%s, paused=%s, threshold=%s, sensor=%s}", isLoaded(), mRegistered, mPaused, mThreshold, mSensor); }