From bcef6ae6bce3c890ca9c231b3a113c57bc48bc9f Mon Sep 17 00:00:00 2001
From: Dan Shi <dshi@google.com>
Date: Fri, 26 Jul 2019 14:16:43 -0700
Subject: [PATCH] Fix dependency on APK used by test

Use data attribute to include the APK used for the test.

Bug: 138416078
Test: atest
Change-Id: Iffeca6c5f487c6a164acb9c880a5b6405eff424d
---
 core/tests/coretests/Android.bp                              | 2 ++
 core/tests/coretests/BstatsTestApp/Android.bp                | 4 ----
 services/tests/servicestests/Android.bp                      | 2 ++
 services/tests/servicestests/test-apps/JobTestApp/Android.bp | 2 --
 tools/preload-check/Android.bp                               | 1 +
 tools/preload-check/device/Android.bp                        | 1 -
 6 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/core/tests/coretests/Android.bp b/core/tests/coretests/Android.bp
index a90948780d9e5..2fa44876e4255 100644
--- a/core/tests/coretests/Android.bp
+++ b/core/tests/coretests/Android.bp
@@ -55,6 +55,8 @@ android_test {
 
     resource_dirs: ["res"],
     resource_zips: [":FrameworksCoreTests_apks_as_resources"],
+
+    data: [":BstatsTestApp"],
 }
 
 // Rules to copy all the test apks to the intermediate raw resource directory
diff --git a/core/tests/coretests/BstatsTestApp/Android.bp b/core/tests/coretests/BstatsTestApp/Android.bp
index 424c71a4d8d07..a89d728306863 100644
--- a/core/tests/coretests/BstatsTestApp/Android.bp
+++ b/core/tests/coretests/BstatsTestApp/Android.bp
@@ -15,10 +15,6 @@
 android_test_helper_app {
     name: "BstatsTestApp",
 
-    test_suites: [
-        "device-tests",
-    ],
-
     static_libs: ["coretests-aidl"],
 
     srcs: ["**/*.java"],
diff --git a/services/tests/servicestests/Android.bp b/services/tests/servicestests/Android.bp
index 153820d4853ef..7c34f4320a7d5 100644
--- a/services/tests/servicestests/Android.bp
+++ b/services/tests/servicestests/Android.bp
@@ -78,6 +78,8 @@ android_test {
     optimize: {
         enabled: false,
     },
+
+    data: [":JobTestApp"],
 }
 
 java_library {
diff --git a/services/tests/servicestests/test-apps/JobTestApp/Android.bp b/services/tests/servicestests/test-apps/JobTestApp/Android.bp
index ae1eca7ba707d..b29e187576c34 100644
--- a/services/tests/servicestests/test-apps/JobTestApp/Android.bp
+++ b/services/tests/servicestests/test-apps/JobTestApp/Android.bp
@@ -17,8 +17,6 @@ android_test_helper_app {
 
     sdk_version: "current",
 
-    test_suites: ["device-tests"],
-
     srcs: ["**/*.java"],
 
     dex_preopt: {
diff --git a/tools/preload-check/Android.bp b/tools/preload-check/Android.bp
index 2488341bfd97b..87b31d22af320 100644
--- a/tools/preload-check/Android.bp
+++ b/tools/preload-check/Android.bp
@@ -19,4 +19,5 @@ java_test_host {
     libs: ["tradefed"],
     test_suites: ["general-tests"],
     required: ["preload-check-device"],
+    data: [":preload-check-device"],
 }
diff --git a/tools/preload-check/device/Android.bp b/tools/preload-check/device/Android.bp
index 7782b0d378ae9..f40d8ba5a287d 100644
--- a/tools/preload-check/device/Android.bp
+++ b/tools/preload-check/device/Android.bp
@@ -20,7 +20,6 @@ java_test_helper_library {
 
     sdk_version: "current",
     srcs: ["src/**/*.java"],
-    test_suites: ["general-tests"],
     dex_preopt: {
         enabled: false,
     },