From c1b9afe693fb7481c999dce1280cb4c6940b5511 Mon Sep 17 00:00:00 2001 From: Jeff DeCew Date: Tue, 14 Dec 2021 15:17:57 -0500 Subject: [PATCH] Fix smart reply lifetime extension The new pipeline was attaching the RemoteInputCoordinator which was mutating state on the SmartReplyController, which was causing that controller to provide the incorrect result to the active pipeline. Removing the coordinator fixes the issue. Fixes: 148255323 Test: use notify to post a notification with a smart reply, tap the reply, notice the notification stays around. Change-Id: I81d447a84fec83e2b1e283766e4aef646d4db486 --- .../notification/collection/coordinator/NotifCoordinators.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/notification/collection/coordinator/NotifCoordinators.kt b/packages/SystemUI/src/com/android/systemui/statusbar/notification/collection/coordinator/NotifCoordinators.kt index d21d5a7a358f0..757fb5a2fe9a3 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/notification/collection/coordinator/NotifCoordinators.kt +++ b/packages/SystemUI/src/com/android/systemui/statusbar/notification/collection/coordinator/NotifCoordinators.kt @@ -91,7 +91,6 @@ class NotifCoordinatorsImpl @Inject constructor( mCoordinators.add(conversationCoordinator) mCoordinators.add(groupCountCoordinator) mCoordinators.add(mediaCoordinator) - mCoordinators.add(remoteInputCoordinator) mCoordinators.add(rowAppearanceCoordinator) mCoordinators.add(stackCoordinator) mCoordinators.add(shadeEventCoordinator) @@ -105,6 +104,7 @@ class NotifCoordinatorsImpl @Inject constructor( mCoordinators.add(headsUpCoordinator) mCoordinators.add(gutsCoordinator) mCoordinators.add(preparationCoordinator) + mCoordinators.add(remoteInputCoordinator) } // Manually add Ordered Sections