From c91318ace9919f51ad91861178e593f5bbb39a0f Mon Sep 17 00:00:00 2001 From: Andrey Epin Date: Thu, 26 May 2022 16:05:00 -0700 Subject: [PATCH 1/2] Fix ResolverDrawerLayout child measurement ResoverDrawerLayout didn't take into account its horizontal paddints when measured its children. Plus a trivial refactoring. Fix: 223775954 Test: Manual test: open Chooser in landscape mode on a phone with 3-button navigation. Change-Id: Ia4835a2ddb52bff4ba36597dea3a3d7bf83967aa --- .../com/android/internal/widget/ResolverDrawerLayout.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/core/java/com/android/internal/widget/ResolverDrawerLayout.java b/core/java/com/android/internal/widget/ResolverDrawerLayout.java index 90eeabb47e9aa..1cdc10866f2c2 100644 --- a/core/java/com/android/internal/widget/ResolverDrawerLayout.java +++ b/core/java/com/android/internal/widget/ResolverDrawerLayout.java @@ -929,7 +929,7 @@ public class ResolverDrawerLayout extends ViewGroup { // Single-use layout; just ignore the mode and use available space. // Clamp to maxWidth. if (mMaxWidth >= 0) { - widthSize = Math.min(widthSize, mMaxWidth); + widthSize = Math.min(widthSize, mMaxWidth + getPaddingLeft() + getPaddingRight()); } final int widthSpec = MeasureSpec.makeMeasureSpec(widthSize, MeasureSpec.EXACTLY); @@ -1008,8 +1008,9 @@ public class ResolverDrawerLayout extends ViewGroup { View indicatorHost = null; int ypos = mTopOffset; - int leftEdge = getPaddingLeft(); - int rightEdge = width - getPaddingRight(); + final int leftEdge = getPaddingLeft(); + final int rightEdge = width - getPaddingRight(); + final int widthAvailable = rightEdge - leftEdge; final int childCount = getChildCount(); for (int i = 0; i < childCount; i++) { @@ -1030,7 +1031,6 @@ public class ResolverDrawerLayout extends ViewGroup { final int bottom = top + child.getMeasuredHeight(); final int childWidth = child.getMeasuredWidth(); - final int widthAvailable = rightEdge - leftEdge; final int left = leftEdge + (widthAvailable - childWidth) / 2; final int right = left + childWidth; From ed20af41ad080cfc3a21198768f328083889012c Mon Sep 17 00:00:00 2001 From: Dan Sandler Date: Thu, 26 May 2022 23:28:30 -0400 Subject: [PATCH 2/2] Triskaidekaphilia intensifies. Bug: 216297617 Test: adb shell am start -n android/com.android.internal.app.PlatLogoActivity Test: Settings > Apps > list system apps Change-Id: I2e5ebca1b5cab4594099638acb552fda8fcc05e1 --- core/res/res/drawable-nodpi/platlogo.xml | 37 ++++++++-------- .../EasterEgg/res/drawable/android_13.xml | 42 +++++++++++++++++++ .../res/drawable/android_13_mono.xml | 31 ++++++++++++++ packages/EasterEgg/res/drawable/icon.xml | 3 +- packages/EasterEgg/res/drawable/icon_bg.xml | 2 +- .../res/drawable-nodpi/android_13.xml | 42 +++++++++++++++++++ .../res/drawable-nodpi/android_13_mono.xml | 31 ++++++++++++++ packages/SystemUI/res/drawable-nodpi/icon.xml | 3 +- .../SystemUI/res/drawable-nodpi/icon_bg.xml | 2 +- 9 files changed, 170 insertions(+), 23 deletions(-) create mode 100644 packages/EasterEgg/res/drawable/android_13.xml create mode 100644 packages/EasterEgg/res/drawable/android_13_mono.xml create mode 100644 packages/SystemUI/res/drawable-nodpi/android_13.xml create mode 100644 packages/SystemUI/res/drawable-nodpi/android_13_mono.xml diff --git a/core/res/res/drawable-nodpi/platlogo.xml b/core/res/res/drawable-nodpi/platlogo.xml index 1d67570cf4851..f816d0c413499 100644 --- a/core/res/res/drawable-nodpi/platlogo.xml +++ b/core/res/res/drawable-nodpi/platlogo.xml @@ -13,24 +13,23 @@ Copyright (C) 2021 The Android Open Source Project See the License for the specific language governing permissions and limitations under the License. --> - - - - + android:viewportHeight="24" + android:viewportWidth="24" + xmlns:android="http://schemas.android.com/apk/res/android"> + + + + + diff --git a/packages/EasterEgg/res/drawable/android_13.xml b/packages/EasterEgg/res/drawable/android_13.xml new file mode 100644 index 0000000000000..edc44ce4eaa31 --- /dev/null +++ b/packages/EasterEgg/res/drawable/android_13.xml @@ -0,0 +1,42 @@ + + + + + + + + \ No newline at end of file diff --git a/packages/EasterEgg/res/drawable/android_13_mono.xml b/packages/EasterEgg/res/drawable/android_13_mono.xml new file mode 100644 index 0000000000000..55c1bcd948310 --- /dev/null +++ b/packages/EasterEgg/res/drawable/android_13_mono.xml @@ -0,0 +1,31 @@ + + + + + \ No newline at end of file diff --git a/packages/EasterEgg/res/drawable/icon.xml b/packages/EasterEgg/res/drawable/icon.xml index 7054962b3503f..cdac1f98be302 100644 --- a/packages/EasterEgg/res/drawable/icon.xml +++ b/packages/EasterEgg/res/drawable/icon.xml @@ -15,5 +15,6 @@ Copyright (C) 2018 The Android Open Source Project --> - + + diff --git a/packages/EasterEgg/res/drawable/icon_bg.xml b/packages/EasterEgg/res/drawable/icon_bg.xml index d08e160ea312b..231b4b802ecce 100644 --- a/packages/EasterEgg/res/drawable/icon_bg.xml +++ b/packages/EasterEgg/res/drawable/icon_bg.xml @@ -14,5 +14,5 @@ Copyright (C) 2018 The Android Open Source Project limitations under the License. --> + android:color="@android:color/system_accent3_400" /> diff --git a/packages/SystemUI/res/drawable-nodpi/android_13.xml b/packages/SystemUI/res/drawable-nodpi/android_13.xml new file mode 100644 index 0000000000000..edc44ce4eaa31 --- /dev/null +++ b/packages/SystemUI/res/drawable-nodpi/android_13.xml @@ -0,0 +1,42 @@ + + + + + + + + \ No newline at end of file diff --git a/packages/SystemUI/res/drawable-nodpi/android_13_mono.xml b/packages/SystemUI/res/drawable-nodpi/android_13_mono.xml new file mode 100644 index 0000000000000..55c1bcd948310 --- /dev/null +++ b/packages/SystemUI/res/drawable-nodpi/android_13_mono.xml @@ -0,0 +1,31 @@ + + + + + \ No newline at end of file diff --git a/packages/SystemUI/res/drawable-nodpi/icon.xml b/packages/SystemUI/res/drawable-nodpi/icon.xml index 997249632709e..cdac1f98be302 100644 --- a/packages/SystemUI/res/drawable-nodpi/icon.xml +++ b/packages/SystemUI/res/drawable-nodpi/icon.xml @@ -15,5 +15,6 @@ Copyright (C) 2018 The Android Open Source Project --> - + + diff --git a/packages/SystemUI/res/drawable-nodpi/icon_bg.xml b/packages/SystemUI/res/drawable-nodpi/icon_bg.xml index f7b0982dfaf8c..231b4b802ecce 100644 --- a/packages/SystemUI/res/drawable-nodpi/icon_bg.xml +++ b/packages/SystemUI/res/drawable-nodpi/icon_bg.xml @@ -14,5 +14,5 @@ Copyright (C) 2018 The Android Open Source Project limitations under the License. --> + android:color="@android:color/system_accent3_400" />